Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed an unused function and minor cleanup #11755

Merged
merged 1 commit into from Jun 16, 2016
Merged

Removed an unused function and minor cleanup #11755

merged 1 commit into from Jun 16, 2016

Conversation

@wafflespeanut
Copy link
Member

wafflespeanut commented Jun 15, 2016 •
edited by larsbergstrom

fixes #11679

This change is Reviewable
@wafflespeanut
Removed unused function and minor cleanup
Loading status checks…
dfe32b0
@highfive
Copy link

highfive commented Jun 15, 2016

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/tidy/servo_tidy_tests/test_tidy.py, python/tidy/servo_tidy/tidy.py
@nox
Copy link
Member

nox commented Jun 16, 2016

@bors-servo r+

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2016

📌 Commit dfe32b0 has been approved by nox
@highfive highfive assigned nox and unassigned Ms2ger Jun 16, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2016

⌛ Testing commit dfe32b0 with merge ff67f80...
bors-servo added a commit that referenced this pull request Jun 16, 2016
@bors-servo
Auto merge of #11755 - Wafflespeanut:tidy_fixes, r=nox
Loading status checks…
ff67f80 
Removed an unused function and minor cleanup

fixes #11679

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11755)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2016

💔 Test failed - mac-rel-wpt
@nox
Copy link
Member

nox commented Jun 16, 2016

@bors-servo retry #11617
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, windows are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit dfe32b0 into servo:master Jun 16, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@wafflespeanut wafflespeanut deleted the wafflespeanut:tidy_fixes branch Jun 16, 2016
@wafflespeanut
Copy link
Member Author

wafflespeanut commented Jun 16, 2016

@nox Thanks! :)
@jdm
Copy link
Member

jdm commented Jun 16, 2016

There was no test for the fix for #11679...
@wafflespeanut
Copy link
Member Author

wafflespeanut commented Jun 16, 2016

I thought it was a minor bug. Sorry, will add a test now :)
@wafflespeanut wafflespeanut mentioned this pull request Jun 16, 2016
Merged
bors-servo added a commit that referenced this pull request Jun 16, 2016
@bors-servo
Auto merge of #11761 - Wafflespeanut:tidy_test, r=emilio
Loading status checks…
17b6370 
Tidy test for ignoring attributes

This should've been done in #11755

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11761)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

tidy warns about problems even in quoted strings inside attributes
6 participants
@wafflespeanut @highfive @nox @bors-servo @jdm @Ms2ger
You can’t perform that action at this time.