Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upURI to URL to address #11450 #11765
Closed
URI to URL to address #11450 #11765
Conversation
highfive
commented
Jun 17, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
highfive
commented
Jun 17, 2016
|
Heads up! This PR modifies the following files:
|
This was referenced Jun 17, 2016
| @@ -67,7 +67,7 @@ pub struct HTMLIFrameElement { | |||
| pipeline_id: Cell<Option<PipelineId>>, | |||
| subpage_id: Cell<Option<SubpageId>>, | |||
| sandbox: MutNullableHeap<JS<DOMTokenList>>, | |||
| sandbox_allowance: Cell<Option<u8>>, | |||
| sandbox_allowance: Cell<Option<SandboxAllowance>>, | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
KiChjang
Jun 17, 2016
Member
Ah I see, this is intended to fix #11599. Please build your branch and fix the compiler errors that result from this change.
|
This fails building in Travis CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Coder206 commentedJun 17, 2016
•
edited by larsbergstrom
@asajeffrey Please note, there is an error and a warning:
Compiling script v0.0.1 (file:///E:/files/dev/github/servo/components/script)
E:\files\dev\github\servo\components\script\dom\xmlhttprequest.rs:1044:5: 1048:6 warning: method is never used:
insert_trusted_header, #[warn(dead_code)] on by defaultE:\files\dev\github\servo\components\script\dom\xmlhttprequest.rs:1044 fn insert_trusted_header(&self, name: String, value: String) {
This change is