Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Blob::{new, new_inherited} to take Strings #11768
Merged
Conversation
highfive
commented
Jun 17, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jun 17, 2016
|
|
components/script/dom/blob.rs
Outdated
| @@ -156,7 +156,7 @@ impl Blob { | |||
| }; | |||
|
|
|||
| let slice = DataSlice::from_bytes(bytes); | |||
| Ok(Blob::new(global, BlobImpl::new_from_slice(slice), &blobPropertyBag.get_typestring())) | |||
| Ok(Blob::new(global, BlobImpl::new_from_slice(slice), blobPropertyBag.get_typestring().to_owned())) | |||
This comment has been minimized.
This comment has been minimized.
components/script/dom/blob.rs
Outdated
| @@ -252,7 +252,7 @@ impl BlobMethods for Blob { | |||
| let global = self.global(); | |||
| let bytes = self.get_slice_or_empty().bytes.clone(); | |||
| let slice = DataSlice::new(bytes, start, end); | |||
| Blob::new(global.r(), BlobImpl::new_from_slice(slice), &relativeContentType) | |||
| Blob::new(global.r(), BlobImpl::new_from_slice(slice), relativeContentType.to_string()) | |||
This comment has been minimized.
This comment has been minimized.
|
Nice job, just two small comments. |
|
Neato, updating. |
|
Thank you! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 17, 2016
Update Blob::{new, new_inherited} to take Strings
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11762.
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because no logic changes, only interface changes.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11768)
<!-- Reviewable:end -->
|
|
highfive
commented
Jun 17, 2016
|
|
@bors-servo retry #11631 |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
achals commentedJun 17, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is