Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused XHR method #11769

Merged
merged 1 commit into from Jun 17, 2016
Merged

Remove unused XHR method #11769

merged 1 commit into from Jun 17, 2016

Conversation

@splav
Copy link
Contributor

splav commented Jun 17, 2016 •
edited

Remove unused XHR method.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #11760 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because it is a cleanup

This change is Reviewable
@splav
Remove unused XHR method
Loading status checks…
520f90c
@highfive
Copy link

highfive commented Jun 17, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon.
@highfive
Copy link

highfive commented Jun 17, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/xmlhttprequest.rs
@highfive
Copy link

highfive commented Jun 17, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jun 17, 2016

@bors-servo: r+
Thanks for the patch!
@bors-servo
Copy link
Contributor

bors-servo commented Jun 17, 2016

📌 Commit 520f90c has been approved by jdm
@highfive highfive assigned jdm and unassigned Ms2ger Jun 17, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 17, 2016

⌛ Testing commit 520f90c with merge 3332e1a...
bors-servo added a commit that referenced this pull request Jun 17, 2016
@bors-servo
Auto merge of #11769 - splav:master, r=jdm
3332e1a 
Remove unused XHR method

<!-- Please describe your changes on the following line: -->
Remove unused XHR method.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11760 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is a cleanup

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11769)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 17, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Jun 17, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 17, 2016

⌛ Testing commit 520f90c with merge fb9f327...
bors-servo added a commit that referenced this pull request Jun 17, 2016
@bors-servo
Auto merge of #11769 - splav:master, r=jdm
Loading status checks…
fb9f327 
Remove unused XHR method

<!-- Please describe your changes on the following line: -->
Remove unused XHR method.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11760 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is a cleanup

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11769)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 17, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Jun 17, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 17, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 17, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 17, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@KiChjang
Copy link
Member

KiChjang commented Jun 17, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 17, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 17, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 520f90c into servo:master Jun 17, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove unused XHR method
6 participants
@splav @highfive @jdm @bors-servo @KiChjang @Ms2ger
You can’t perform that action at this time.