Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment is wrong. #11786

Merged
merged 1 commit into from Jun 18, 2016
Merged

Alignment is wrong. #11786

merged 1 commit into from Jun 18, 2016

Conversation

@notriddle
Copy link
Contributor

notriddle commented Jun 18, 2016 •
edited by larsbergstrom

Fix off-alignment.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not fix any particular issue number
  • These changes do not require tests because refactoring

This change is Reviewable
@notriddle
Alignment is wrong.
Loading status checks…
b082dce
@highfive
Copy link

highfive commented Jun 18, 2016

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jun 18, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2016

📌 Commit b082dce has been approved by jdm
@highfive highfive assigned jdm and unassigned SimonSapin Jun 18, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2016

⌛ Testing commit b082dce with merge 2cea418...
bors-servo added a commit that referenced this pull request Jun 18, 2016
@bors-servo
Auto merge of #11786 - notriddle:cleanup, r=jdm
Loading status checks…
2cea418 
Alignment is wrong.

Fix off-alignment.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not fix any particular issue number
- [X] These changes do not require tests because refactoring

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11786)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 18, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@notriddle
Copy link
Contributor Author

notriddle commented Jun 18, 2016 •
edited

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit b082dce into servo:master Jun 18, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@notriddle notriddle deleted the notriddle:cleanup branch Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@notriddle @highfive @jdm @bors-servo @SimonSapin
You can’t perform that action at this time.