Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent some warnings #11788

Merged
merged 2 commits into from Jun 19, 2016
Merged

Silent some warnings #11788

merged 2 commits into from Jun 19, 2016

Conversation

@UK992
Copy link
Contributor

UK992 commented Jun 18, 2016

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because only silent some warnings

This change is Reviewable

@highfive
Copy link

highfive commented Jun 18, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/filemanager_thread.rs
@jdm
Copy link
Member

jdm commented Jun 19, 2016

@bors-servo: r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Jun 19, 2016

📌 Commit 3ad4189 has been approved by jdm

@highfive highfive assigned jdm and unassigned asajeffrey Jun 19, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 19, 2016

Testing commit 3ad4189 with merge 7eb507c...

bors-servo added a commit that referenced this pull request Jun 19, 2016
Silent some warnings

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because only silent some warnings

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11788)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 19, 2016

💔 Test failed - mac-rel-wpt

@wafflespeanut
Copy link
Member

wafflespeanut commented Jun 19, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jun 19, 2016

Testing commit 3ad4189 with merge 95941cb...

bors-servo added a commit that referenced this pull request Jun 19, 2016
Silent some warnings

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because only silent some warnings

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11788)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 19, 2016

@bors-servo bors-servo merged commit 3ad4189 into servo:master Jun 19, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@UK992 UK992 deleted the UK992:warnings branch Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.