Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upURI to URL #11789
Merged
URI to URL #11789
Conversation
highfive
commented
Jun 18, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
highfive
commented
Jun 18, 2016
|
Heads up! This PR modifies the following files:
|
|
@asajeffrey I think I got the hang of Git now. |
|
@wafflespeanut Did I PR correctly this time? |
|
Yep! Good work! Feel free to ping us at IRC when you have trouble with something (btw, you don't have to open a new PR every time you fix your commits - fixing the old commits and [force] pushing it to the same branch replaces your old commits with the new ones) |
|
@wafflespeanut Thanks! I actually just recreated my work space for Servo on my computer to un-merge from the master branch. |
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Jun 19, 2016
URI to URL <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [x] These changes fix #11450 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11789) <!-- Reviewable:end -->
|
|
|
The tests |
| @@ -19,7 +19,7 @@ | |||
| iframe.src = url1; | |||
|
|
|||
| iframe.addEventListener("mozbrowserlocationchange", e => { | |||
| locations.push(e.detail.uri); | |||
| locations.push(e.detail.url); | |||
| if (e.detail.uri == url2) { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@jdm Thanks :) |
|
@jdm That is what I was trying to see! :) |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jun 20, 2016
URI to URL <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [x] These changes fix #11450 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11789) <!-- Reviewable:end -->
|
|
|
That's #11703. |
|
Please squash the commits together. |
|
@KiChjang: Below is what I meant on IRC yesterday. |
trying to pass test - uri
|
@nox Squash completed! :) Learning lots about Git!! (special thanks to @ConnorGBrewster) |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 21, 2016
URI to URL <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #11450 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes (Windows 10 was never able to run them...) <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11789) <!-- Reviewable:end -->
|
|
|
@bors-servo retry #11693 |
|
|
|
|
|
@wafflespeanut Thanks :) |
|
Yay, it merged, thanks for all the work @Coder206! On Tue, Jun 21, 2016 at 5:06 AM, Coder206 notifications@github.com wrote:
|
|
@asajeffrey Thanks for your help as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Coder206 commentedJun 18, 2016
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is