Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrender: Don't use OpenGL round() for snapping pixels #11801

Merged
merged 1 commit into from Jun 30, 2016
Merged

webrender: Don't use OpenGL round() for snapping pixels #11801

merged 1 commit into from Jun 30, 2016

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 20, 2016 •
edited by larsbergstrom

Fixes #11751. See servo/webrender#294 for some details. r? @pcwalton

This change is Reviewable
@mbrubeck mbrubeck mentioned this pull request Jun 27, 2016
Closed
@pcwalton
Copy link
Contributor

pcwalton commented Jun 27, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

📌 Commit 37bc709 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

⌛ Testing commit 37bc709 with merge 54e4b63...
bors-servo added a commit that referenced this pull request Jun 27, 2016
@bors-servo
Auto merge of #11801 - mbrubeck:snaptopix, r=pcwalton
54e4b63 
webrender: Don't use OpenGL round() for snapping pixels

Fixes #11751. See servo/webrender#294 for some details. r? @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11801)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

💔 Test failed - android
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Jun 27, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

⌛ Testing commit 37bc709 with merge aa07f22...
bors-servo added a commit that referenced this pull request Jun 27, 2016
@bors-servo
Auto merge of #11801 - mbrubeck:snaptopix, r=pcwalton
aa07f22 
webrender: Don't use OpenGL round() for snapping pixels

Fixes #11751. See servo/webrender#294 for some details. r? @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11801)
<!-- Reviewable:end -->
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Jun 27, 2016

The new reftest is failing on Mac; the spacing between some pairs of letters (e.g. the first two) is off by one pixel:

screenshot at 2016-06-27 13-04-02
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Jun 27, 2016 

  ▶ FAIL [expected PASS] /_mozilla/css/pixel_snapping_glyphs.html
  └   → /_mozilla/css/pixel_snapping_glyphs.html 1cb5dae59968e4007cb1578510345de4ab657814
/_mozilla/css/pixel_snapping_glyphs_ref.html 7fade70ea96b990de344cdb3ad26b23736330803
Testing 1cb5dae59968e4007cb1578510345de4ab657814 == 7fade70ea96b990de344cdb3ad26b23736330803
@mbrubeck
webrender: Don't use OpenGL round() for snapping pixels
Loading status checks…
6c00058 
Fixes #11751.
@mbrubeck mbrubeck force-pushed the mbrubeck:snaptopix branch from 37bc709 to 6c00058 Jun 30, 2016
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Jun 30, 2016

@bors-servo r=pcwalton

Marked the new test as failing on Mac for now, after confirming that it fails the same without this PR. Will file a follow-up for the positioning issues on Mac.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

📌 Commit 6c00058 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

⌛ Testing commit 6c00058 with merge 30a95e2...
bors-servo added a commit that referenced this pull request Jun 30, 2016
@bors-servo
Auto merge of #11801 - mbrubeck:snaptopix, r=pcwalton
30a95e2 
webrender: Don't use OpenGL round() for snapping pixels

Fixes #11751. See servo/webrender#294 for some details. r? @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11801)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 30, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@cbrewster
Copy link
Member

cbrewster commented Jun 30, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

⌛ Testing commit 6c00058 with merge 461d7c4...
bors-servo added a commit that referenced this pull request Jun 30, 2016
@bors-servo
Auto merge of #11801 - mbrubeck:snaptopix, r=pcwalton
Loading status checks…
461d7c4 
webrender: Don't use OpenGL round() for snapping pixels

Fixes #11751. See servo/webrender#294 for some details. r? @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11801)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 6c00058 into servo:master Jun 30, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck deleted the mbrubeck:snaptopix branch May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mbrubeck @pcwalton @bors-servo @highfive @cbrewster
You can’t perform that action at this time.