Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a layout_thread crate; drop the dependency of layout on script. #11804

Merged
merged 3 commits into from Jun 21, 2016
Merged

Introduce a layout_thread crate; drop the dependency of layout on script. #11804

merged 3 commits into from Jun 21, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 20, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 3 commits Jun 17, 2016
@Ms2ger
Move LayoutThreadData to query.rs.
55a9310
@Ms2ger
Move DISPLAY_PORT_SIZE_FACTOR to block.rs.
7414eda
@Ms2ger
Introduce a layout_thread crate; drop the dependency of layout on scr…
Loading status checks…
6528bee 
…ipt.
@highfive
Copy link

highfive commented Jun 20, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jun 20, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2016

📌 Commit 6528bee has been approved by jdm
@highfive highfive assigned jdm and unassigned glennw Jun 20, 2016
@jdm
Copy link
Member

jdm commented Jun 20, 2016

Impressive!
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2016

⌛ Testing commit 6528bee with merge a94d3ee...
bors-servo added a commit that referenced this pull request Jun 20, 2016
@bors-servo
Auto merge of #11804 - Ms2ger:layout-thread-crate, r=jdm
Loading status checks…
a94d3ee 
Introduce a layout_thread crate; drop the dependency of layout on script.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11804)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 20, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@jdm
Copy link
Member

jdm commented Jun 20, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 6528bee into servo:master Jun 21, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jun 21, 2016
Merged
3 of 3 tasks complete
@jdm jdm mentioned this pull request Jun 23, 2016
Closed
@rzambre rzambre mentioned this pull request Jun 23, 2016
Closed
@Ms2ger Ms2ger deleted the Ms2ger:layout-thread-crate branch Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @jdm @bors-servo @glennw
You can’t perform that action at this time.