Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a border to the logo to differentiate from background color. #11814

Merged
merged 1 commit into from Jun 21, 2016
Merged

Add a border to the logo to differentiate from background color. #11814

merged 1 commit into from Jun 21, 2016

Conversation

@jdm
Copy link
Member

jdm commented Jun 21, 2016 •
edited by larsbergstrom

By @zmike from #11473 (comment).

This change is Reviewable
@jdm
Add a border to the logo to differentiate from background color.
Loading status checks…
e7d0f04
@metajack
Copy link
Contributor

metajack commented Jun 21, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2016

📌 Commit e7d0f04 has been approved by metajack
@highfive highfive assigned metajack and unassigned pcwalton Jun 21, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2016

⌛ Testing commit e7d0f04 with merge 9dbf7b4...
bors-servo added a commit that referenced this pull request Jun 21, 2016
@bors-servo
Auto merge of #11814 - jdm:fancy-logo, r=metajack
Loading status checks…
9dbf7b4 
Add a border to the logo to differentiate from background color.

By @zmike from #11473 (comment).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11814)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented Jun 21, 2016

cc @Coder206
@Coder206
Copy link
Contributor

Coder206 commented Jun 21, 2016 •
edited

@jdm @zmike There still isn't much visibility of your new icon on a Windows 10 system, see below:
servo_b
Initial:
servo

Perhaps making the border slightly thicker?
@Coder206
Copy link
Contributor

Coder206 commented Jun 21, 2016 •
edited

servobb
Take a look at the last logo found here: http://imgur.com/a/JkclL
I find it really makes the border more visible. I am not a fan of the background color nor the low resolution but maybe reworking this new logo just a bit might pay off for Windows 10. Also I realize the logo that this post features has an unfair advantage of a background color. Please note, I am just comparing the white and the black lines on the logo when making my comment here.

In Windows 10, you can change the task bar color but I think black is the default.

I do realize there has already been a decision here...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member Author

jdm commented Jun 21, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit e7d0f04 into servo:master Jun 21, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @metajack @bors-servo @Coder206 @pcwalton @highfive
You can’t perform that action at this time.