Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating a LayoutContext in parallel::assign_inline_sizes. #11822

Merged
merged 14 commits into from Jun 23, 2016
Merged

Avoid creating a LayoutContext in parallel::assign_inline_sizes. #11822

merged 14 commits into from Jun 23, 2016
+127 −112

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 22, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 14 commits Jun 20, 2016
@Ms2ger
Pass SharedStyleContext to adjust_fragments_for_collapsed_margins_if_…
e6435b7 
…root.
@Ms2ger
Pass SharedStyleContext to calculate_absolute_block_size_and_margins.
e142b78
@Ms2ger
Store SharedStyleContext in AbsoluteAssignBSizesTraversal.
6f4b8f2
@Ms2ger
Pass SharedStyleContext to explicit_block_containing_size.
f20ea08
@Ms2ger
Pass SharedStyleContext to containing_block_inline_size.
2a1e2f4
@Ms2ger
Pass SharedStyleContext to initial_computed_inline_size.
5c12755
@Ms2ger
Pass SharedStyleContext to compute_inline_size_constraint_inputs.
018bebe
@Ms2ger
Pass SharedStyleContext to compute_used_inline_size.
9731a00
@Ms2ger
Pass SharedStyleContext to TableWrapperFlow::compute_used_inline_size.
959f8c1
@Ms2ger
Pass SharedStyleContext to propagate_assigned_inline_size_to_children.
21b8d2b
@Ms2ger
Pass SharedStyleContext to propagate_and_compute_used_inline_size.
c33ac87
@Ms2ger
Pass SharedStyleContext to compute_inline_sizes.
ea15f69
@Ms2ger
Pass SharedStyleContext to assign_inline_sizes.
ea45e76
@Ms2ger
Store SharedStyleContext in AssignISizes.
Loading status checks…
577c2d2
@highfive
Copy link

highfive commented Jun 22, 2016

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Jun 23, 2016

@bors-servo r+ p=1

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, 3 of 3 files at r4, 2 of 2 files at r5, 2 of 2 files at r6, 3 of 3 files at r7, 6 of 6 files at r8, 1 of 1 files at r9, 7 of 7 files at r10, 1 of 1 files at r11, 2 of 2 files at r12, 14 of 14 files at r13, 3 of 3 files at r14.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jun 23, 2016

📌 Commit 577c2d2 has been approved by nox
@highfive highfive assigned nox and unassigned Manishearth Jun 23, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 23, 2016

⌛ Testing commit 577c2d2 with merge 44b0bdd...
bors-servo added a commit that referenced this pull request Jun 23, 2016
@bors-servo
Auto merge of #11822 - Ms2ger:sharedcontext, r=nox
Loading status checks…
44b0bdd 
Avoid creating a LayoutContext in parallel::assign_inline_sizes.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11822)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 23, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 23, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jun 23, 2016

@bors-servo retry #11574
@bors-servo
Copy link
Contributor

bors-servo commented Jun 23, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 23, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 577c2d2 into servo:master Jun 23, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:sharedcontext branch Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @nox @bors-servo @Manishearth
You can’t perform that action at this time.