Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGenerate geckolib structs with -no-bitfield-methods #11827
Merged
+17
−492
Conversation
|
@bors-servo: r+ Thanks for doing this! :) |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 22, 2016
Generate geckolib structs with -no-bitfield-methods <!-- Please describe your changes on the following line: --> This makes rust-bindgen not generate a bunch of methods that were not used, including `const fn` ones. This helps with #11815 since `const fn` is unstable. (Note that running `regen_style_structs.sh` without changing it made a bunch of unrelated changes to `structs_*.rs`, probably because I had a different Gecko version. I first made a commit of that, then added `-no-bitfield-methods`, regenerated, made another commit, then removed the first commit with `git rebase -i master@{u}`.) r? @emilio --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #11815 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require new tests because they’re only removing dead code. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11827) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedJun 22, 2016
•
edited
This makes rust-bindgen not generate a bunch of methods that were not used, including
const fnones.This helps with #11815 since
const fnis unstable.(Note that running
regen_style_structs.shwithout changing it made a bunch of unrelated changes tostructs_*.rs, probably because I had a different Gecko version. I first made a commit of that, then added-no-bitfield-methods, regenerated, made another commit, then removed the first commit withgit rebase -i master@{u}.)r? @emilio
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is