Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some documentation to the style crate. #11834

Merged
merged 1 commit into from Jun 27, 2016
Merged

Add some documentation to the style crate. #11834

merged 1 commit into from Jun 27, 2016
+123 −21

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 23, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Jun 23, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/stylesheets.rs, components/style/lib.rs, components/style/error_reporting.rs, components/style/custom_properties.rs, components/style/data.rs, components/style/element_state.rs, components/style/media_queries.rs, components/style/selector_matching.rs, components/style/traversal.rs, components/style/restyle_hints.rs, components/style/attr.rs, components/style/font_face.rs, components/style/dom.rs, components/style/parser.rs, components/style/viewport.rs, components/style/servo.rs, components/style/selector_impl.rs, components/style/values.rs, components/style/animation.rs, components/style/context.rs, components/style/matching.rs
@highfive
Copy link

highfive commented Jun 23, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jun 23, 2016

r? @SimonSapin or someone else who can actually tell me how to improve those :)
@highfive highfive assigned SimonSapin and unassigned KiChjang Jun 23, 2016
@SimonSapin
Copy link
Member

SimonSapin commented Jun 27, 2016

r=me with one additional URL

Reviewed 21 of 21 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

components/style/values.rs, line 5 [r1] (raw file):

 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

//! Common values used in CSS.

Maybe link to https://drafts.csswg.org/css-values/ ? This Rust module and spec module don’t map 1:1, but they have a lot of overlap.

Comments from Reviewable
@Ms2ger
Add some documentation to the style crate.
Loading status checks…
79e0d18
@Ms2ger Ms2ger force-pushed the style-docs branch from 1bb3a7e to 79e0d18 Jun 27, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jun 27, 2016

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

📌 Commit 79e0d18 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

⌛ Testing commit 79e0d18 with merge 2a953ad...
bors-servo added a commit that referenced this pull request Jun 27, 2016
@bors-servo
Auto merge of #11834 - servo:style-docs, r=SimonSapin
2a953ad 
Add some documentation to the style crate.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11834)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 27, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@cbrewster
Copy link
Member

cbrewster commented Jun 27, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

⌛ Testing commit 79e0d18 with merge 88d864a...
bors-servo added a commit that referenced this pull request Jun 27, 2016
@bors-servo
Auto merge of #11834 - servo:style-docs, r=SimonSapin
88d864a 
Add some documentation to the style crate.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11834)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

💔 Test failed - mac-rel-css
@jdm
Copy link
Member

jdm commented Jun 27, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

⌛ Testing commit 79e0d18 with merge 3809e4a...
bors-servo added a commit that referenced this pull request Jun 27, 2016
@bors-servo
Auto merge of #11834 - servo:style-docs, r=SimonSapin
Loading status checks…
3809e4a 
Add some documentation to the style crate.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11834)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 27, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 79e0d18 into master Jun 27, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Jun 27, 2016
Merged
Merged
@wafflespeanut wafflespeanut deleted the style-docs branch Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@Ms2ger @highfive @SimonSapin @bors-servo @cbrewster @jdm @KiChjang
You can’t perform that action at this time.