Send log messages to the constellation #11841

asajeffrey · 2016-06-23T17:12:36Z

Send all warnings and errors to the constellation. Warnings are bufferred up, and included in any subsequent error reports. Errors are reported in the same way as panics.

Note that this can't merge yet, as it needs rust-lang/log#86 to land.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #11776 (github issue number if applicable).
These changes do not require tests because we don't test crash reporting.

This change is

highfive · 2016-06-23T17:12:39Z

Heads up! This PR modifies the following files:

@KiChjang: components/script_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/script_traits/lib.rs, components/script_traits/lib.rs

asajeffrey · 2016-06-23T17:32:27Z

Rebased.

bors-servo · 2016-07-03T16:57:32Z

☔ The latest upstream changes (presumably #12178) made this pull request unmergeable. Please resolve the merge conflicts.

asajeffrey · 2016-07-11T16:54:23Z

rust-lang/log#86 has landed, it just needs to make its way to crates.io.

asajeffrey · 2016-07-11T17:35:25Z

Rebased.

asajeffrey · 2016-07-11T18:35:06Z

env_logger 0.3.4 is now out, so this can merge. r? @Ms2ger


        Removed panic channel. Once servo#11841 lands, this will be replaced …

…by integrated logging and issue reporting.


        Removed panic channel. Once servo#11841 lands, this will be replaced …

…by integrated logging and issue reporting.

Manishearth · 2016-07-15T10:49:10Z

components/constellation/constellation.rs

@@ -304,6 +312,97 @@ enum ExitPipelineMode {
    Force,
 }

+/// A logger directed at the constellation from content processes
+#[derive(Clone)]
+pub struct FromScriptLogger {


We could probably have a FromLogger<T> struct with a common Log impl, where T is FromFooMsg, and implements a trait which provides a get_msg(Option<PipelineId>, Option<String>, LogEntry) -> Self method

Manishearth · 2016-07-15T10:49:25Z

r=me with or without that trait abstraction

asajeffrey · 2016-07-15T14:38:23Z

I think since there's only two instances, the extra level of generality won't buy us that much. Thanks for looking the code over!

@bors-servo r=Manishearth

bors-servo · 2016-07-15T14:38:24Z

📌 Commit bc1dd50 has been approved by Manishearth

bors-servo · 2016-07-15T14:40:17Z

⌛ Testing commit bc1dd50 with merge d97d297...


        Auto merge of #11841 - asajeffrey:constellation-logging, r=Manishearth

Send log messages to the constellation  Send all warnings and errors to the constellation. Warnings are bufferred up, and included in any subsequent error reports. Errors are reported in the same way as panics. Note that this can't merge yet, as it needs rust-lang/log#86 to land. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11776 (github issue number if applicable). - [X] These changes do not require tests because we don't test crash reporting.   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11841)

bors-servo · 2016-07-15T15:36:45Z

💔 Test failed - linux-rel

highfive · 2016-07-15T15:36:47Z

  ▶ Unexpected subtest result in /workers/WorkerGlobalScope_close.htm:
  └ PASS [expected FAIL]  WorkerGlobalScope close(): clear events queue

asajeffrey · 2016-07-15T16:09:59Z

OK, that's weird, did I accidentally fix a bug?

asajeffrey · 2016-07-15T17:03:40Z

IRC conversation: http://logs.glob.uno/?c=mozilla%23servo&s=15+Jul+2016&e=15+Jul+2016#c480756

TL;DR: when logs are reported to the constellation, we can check to see if the thread has panicked, and report Errors as Panics. The issue reporting and hard-failing mechanism can then just be used for panic, in particular hard-fail won't be triggered by JS errors.

asajeffrey · 2016-07-15T18:28:46Z

@Manishearth care to look over that last commit?


        Sent log messages to the constellation.

asajeffrey · 2016-07-15T18:45:52Z

Squashed.

@bors-servo r=Manishearth (http://logs.glob.uno/?c=mozilla%23servo&s=15+Jul+2016&e=15+Jul+2016#c480930)

bors-servo · 2016-07-15T18:45:53Z

📌 Commit 4442274 has been approved by Manishearth

bors-servo · 2016-07-15T18:46:21Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #12441

bors-servo · 2016-07-15T18:46:21Z

📌 Commit 4442274 has been approved by Manishearth

asajeffrey · 2016-07-15T19:12:43Z

@bors-servo retry

CI oddness

bors-servo · 2016-07-15T19:22:27Z

⌛ Testing commit 4442274 with merge a5cd4b9...


        Auto merge of #11841 - asajeffrey:constellation-logging, r=Manishearth

Send log messages to the constellation  Send all warnings and errors to the constellation. Warnings are bufferred up, and included in any subsequent error reports. Errors are reported in the same way as panics. Note that this can't merge yet, as it needs rust-lang/log#86 to land. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11776 (github issue number if applicable). - [X] These changes do not require tests because we don't test crash reporting.   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11841)

bors-servo · 2016-07-15T20:22:48Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows


        Removed panic channel. Once servo#11841 lands, this will be replaced …

…by integrated logging and issue reporting.

highfive assigned SimonSapin Jun 23, 2016

highfive added the S-awaiting-review label Jun 23, 2016

asajeffrey force-pushed the asajeffrey:constellation-logging branch from 1673b5f to cdcc1e8 Jun 23, 2016

Ms2ger assigned Ms2ger and unassigned SimonSapin Jun 27, 2016

asajeffrey mentioned this pull request Jun 28, 2016

Made Logger public. rust-lang/log#86

Merged

highfive added the S-needs-rebase label Jul 3, 2016

asajeffrey force-pushed the asajeffrey:constellation-logging branch from cdcc1e8 to ad862c0 Jul 11, 2016

asajeffrey removed the S-needs-rebase label Jul 11, 2016

jdm added the S-fails-travis label Jul 11, 2016

asajeffrey force-pushed the asajeffrey:constellation-logging branch from ad862c0 to 0ce4055 Jul 11, 2016

asajeffrey changed the title ~~Sent log messages to the constellation [DO NOT MERGE YET]~~ Send log messages to the constellation Jul 11, 2016

asajeffrey removed the S-fails-travis label Jul 11, 2016

asajeffrey added a commit to asajeffrey/servo that referenced this pull request Jul 14, 2016

Removed panic channel. Once servo#11841 lands, this will be replaced …

76d0550

…by integrated logging and issue reporting.

asajeffrey added a commit to asajeffrey/servo that referenced this pull request Jul 14, 2016

Removed panic channel. Once servo#11841 lands, this will be replaced …

7d018b0

…by integrated logging and issue reporting.

Manishearth reviewed Jul 15, 2016
View changes

highfive assigned Manishearth and unassigned Ms2ger Jul 15, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 15, 2016

asajeffrey mentioned this pull request Jul 15, 2016

Replace any errors caused by content-provided URLs by warnings. #12463

Merged

3 of 3 tasks complete

highfive removed the S-awaiting-merge label Jul 15, 2016

highfive added the S-tests-failed label Jul 15, 2016

highfive added S-awaiting-review and removed S-tests-failed labels Jul 15, 2016

asajeffrey added the S-needs-squash label Jul 15, 2016

Sent log messages to the constellation.

Loading status checks…

4442274

asajeffrey force-pushed the asajeffrey:constellation-logging branch from eccd395 to 4442274 Jul 15, 2016

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-squash labels Jul 15, 2016

bors-servo merged commit 4442274 into servo:master Jul 15, 2016
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jul 15, 2016

bors-servo mentioned this pull request Jul 15, 2016

Allow window elements as well as iframes to the the target of mozbrowser events #12426

Merged

4 of 4 tasks complete

asajeffrey added a commit to asajeffrey/servo that referenced this pull request Jul 15, 2016

Removed panic channel. Once servo#11841 lands, this will be replaced …

1bbf56f

…by integrated logging and issue reporting.

servo / servo

Send log messages to the constellation #11841

Send log messages to the constellation #11841

asajeffrey commented Jun 23, 2016 •

edited by larsbergstrom

highfive commented Jun 23, 2016

asajeffrey commented Jun 23, 2016

bors-servo commented Jul 3, 2016

asajeffrey commented Jul 11, 2016

asajeffrey commented Jul 11, 2016

asajeffrey commented Jul 11, 2016

This comment has been minimized.

Manishearth commented Jul 15, 2016

asajeffrey commented Jul 15, 2016

bors-servo commented Jul 15, 2016

bors-servo commented Jul 15, 2016

bors-servo commented Jul 15, 2016

highfive commented Jul 15, 2016

asajeffrey commented Jul 15, 2016

asajeffrey commented Jul 15, 2016

asajeffrey commented Jul 15, 2016

asajeffrey commented Jul 15, 2016 •

edited

bors-servo commented Jul 15, 2016

bors-servo commented Jul 15, 2016

bors-servo commented Jul 15, 2016

asajeffrey commented Jul 15, 2016

bors-servo commented Jul 15, 2016

bors-servo commented Jul 15, 2016

servo / servo

Join GitHub today

Send log messages to the constellation #11841

Send log messages to the constellation #11841

Conversation

asajeffrey commented Jun 23, 2016 • edited by larsbergstrom

highfive commented Jun 23, 2016

asajeffrey commented Jun 23, 2016

bors-servo commented Jul 3, 2016

asajeffrey commented Jul 11, 2016

asajeffrey commented Jul 11, 2016

asajeffrey commented Jul 11, 2016

This comment has been minimized.

Manishearth Jul 15, 2016

Manishearth commented Jul 15, 2016

asajeffrey commented Jul 15, 2016

bors-servo commented Jul 15, 2016

bors-servo commented Jul 15, 2016

bors-servo commented Jul 15, 2016

highfive commented Jul 15, 2016

asajeffrey commented Jul 15, 2016

asajeffrey commented Jul 15, 2016

asajeffrey commented Jul 15, 2016

asajeffrey commented Jul 15, 2016 • edited

bors-servo commented Jul 15, 2016

bors-servo commented Jul 15, 2016

bors-servo commented Jul 15, 2016

asajeffrey commented Jul 15, 2016

bors-servo commented Jul 15, 2016

bors-servo commented Jul 15, 2016

asajeffrey commented Jun 23, 2016 •

edited by larsbergstrom

asajeffrey commented Jul 15, 2016 •

edited