Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor attribute handling to avoid marshalling attributes from Gecko into Servo #11886

Merged
merged 11 commits into from Jul 6, 2016

Disable align-items in geckolib.

  • Loading branch information
heycam authored and bholley committed Jul 6, 2016
commit fd09035c65052b8c6ce1e1becd61701244a10425
@@ -77,11 +77,14 @@ ${helpers.single_keyword("justify-content", "flex-start flex-end center space-be
products="servo",
animatable=False)}

// FIXME(heycam): Disable align-items in geckolib since we don't support the Gecko initial value
// 'normal' yet.
${helpers.single_keyword("align-items", "stretch flex-start flex-end center baseline",
experimental=True,
need_clone=True,
gecko_constant_prefix="NS_STYLE_ALIGN",
animatable=False)}
animatable=False,
products="servo")}

${helpers.single_keyword("align-content", "stretch flex-start flex-end center space-between space-around",
experimental=True,
@@ -1921,6 +1921,7 @@ pub fn cascade<C: ComputedValues>(
}
}

% if "align-items" in data.longhands_by_name:
{
use self::style_struct_traits::Position;
use computed_values::align_self::T as align_self;
@@ -1937,6 +1938,7 @@ pub fn cascade<C: ComputedValues>(
style.mutate_position().set_align_self(self_align);
}
}
% endif

// The initial value of border-*-width may be changed at computed value time.
% for side in ["top", "right", "bottom", "left"]:
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.