Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded checks that selection is valid, and fix set_selection_range. #11906
Conversation
highfive
commented
Jun 28, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jun 28, 2016
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 28, 2016
…ewster Added checks that selection is valid, and fix set_selection_range. <!-- Please describe your changes on the following line: --> Fixed range checking for text inputs. Included some `debug_assert!` statements to check that the selection range is always valid. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11901. - [X] These changes do not require tests because the code includes debug_asserts to ensure invariants are maintained. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11906) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jun 28, 2016
…ewster Added checks that selection is valid, and fix set_selection_range. <!-- Please describe your changes on the following line: --> Fixed range checking for text inputs. Included some `debug_assert!` statements to check that the selection range is always valid. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11901. - [X] These changes do not require tests because the code includes debug_asserts to ensure invariants are maintained. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11906) <!-- Reviewable:end -->
|
No test? |
|
|
|
@jdm yeah might be good to add a test. Would a unit test work? |
|
If a unit test can reproduce the problem, I'm fine with it. |
|
Some IRC chat: http://logs.glob.uno/?c=mozilla%23servo&s=29+Jun+2016&e=29+Jun+2016#c465777 TL;DR: unsigned long parameters to webIDL functions are truncated to the range |
|
Squashed. @bors-servo r=ConnorGBrewster |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 29, 2016
…ewster Added checks that selection is valid, and fix set_selection_range. <!-- Please describe your changes on the following line: --> Fixed range checking for text inputs. Included some `debug_assert!` statements to check that the selection range is always valid. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11901. - [X] These changes do not require tests because the code includes debug_asserts to ensure invariants are maintained. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11906) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Jun 29, 2016
…ewster Added checks that selection is valid, and fix set_selection_range. <!-- Please describe your changes on the following line: --> Fixed range checking for text inputs. Included some `debug_assert!` statements to check that the selection range is always valid. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11901. - [X] These changes do not require tests because the code includes debug_asserts to ensure invariants are maintained. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11906) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jun 29, 2016
…ewster Added checks that selection is valid, and fix set_selection_range. <!-- Please describe your changes on the following line: --> Fixed range checking for text inputs. Included some `debug_assert!` statements to check that the selection range is always valid. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11901. - [X] These changes do not require tests because the code includes debug_asserts to ensure invariants are maintained. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11906) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJun 28, 2016
•
edited by larsbergstrom
Fixed range checking for text inputs. Included some
debug_assert!statements to check that the selection range is always valid../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is