Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSwitch the default renderer to WebRender #11923
Closed
Conversation
highfive
commented
Jun 29, 2016
|
Heads up! This PR modifies the following files:
|
components/util/opts.rs
Outdated
| let use_webrender = | ||
| (prefs::get_pref("gfx.webrender.enabled").as_boolean().unwrap() || opt_match.opt_present("w")) && | ||
| !opt_match.opt_present("z"); | ||
| let use_webrender = !opt_match.opt_present("c"); |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jun 29, 2016
DO NOT MERGE!! Switch the default renderer to WebRender @larsbergstrom I updated your PR to switch the WPT test runner to use WR, make it default on the command line, and include the differing test expectations. I'd personally prefer we had time to fix / update some of those test expectations properly - but if you feel it's urgent enough to merge for the tech demo, we could file follow up bugs to fix up some of the differing tests / expectations. Thoughts? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11923) <!-- Reviewable:end -->
Ms2ger
changed the title
|
@bors-servo r=larsbergstrom,ms2ger,glennw |
|
|
|
|
|
@bors-servo retry |
|
|
|
|
|
@bors-servo try- clean retry |
bors-servo
added a commit
that referenced
this pull request
Jun 29, 2016
…s2ger,glennw Switch the default renderer to WebRender @larsbergstrom I updated your PR to switch the WPT test runner to use WR, make it default on the command line, and include the differing test expectations. I'd personally prefer we had time to fix / update some of those test expectations properly - but if you feel it's urgent enough to merge for the tech demo, we could file follow up bugs to fix up some of the differing tests / expectations. Thoughts? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11923) <!-- Reviewable:end -->
|
|
|
Lots of errors like: |
|
|
|
Rebased this over conflicts, and to get the WR update which lowers shader version on Linux. |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jul 14, 2016
Switch the default renderer to WebRender @larsbergstrom I updated your PR to switch the WPT test runner to use WR, make it default on the command line, and include the differing test expectations. I'd personally prefer we had time to fix / update some of those test expectations properly - but if you feel it's urgent enough to merge for the tech demo, we could file follow up bugs to fix up some of the differing tests / expectations. Thoughts? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11923) <!-- Reviewable:end -->
|
|
|
That's... 2103 test failures and 4 test passes. |
|
@bors-servo try |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2016
Switch the default renderer to WebRender @larsbergstrom I updated your PR to switch the WPT test runner to use WR, make it default on the command line, and include the differing test expectations. I'd personally prefer we had time to fix / update some of those test expectations properly - but if you feel it's urgent enough to merge for the tech demo, we could file follow up bugs to fix up some of the differing tests / expectations. Thoughts? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11923) <!-- Reviewable:end -->
|
|
highfive
commented
Jul 19, 2016
|
|
|
|
Superseded by #13382. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedJun 29, 2016
•
edited by larsbergstrom
@larsbergstrom I updated your PR to switch the WPT test runner to use WR, make it default on the command line, and include the differing test expectations.
I'd personally prefer we had time to fix / update some of those test expectations properly - but if you feel it's urgent enough to merge for the tech demo, we could file follow up bugs to fix up some of the differing tests / expectations.
Thoughts?
This change is