Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Cleanup `Interpolate` code. #11924
Merged
Conversation
highfive
commented
Jun 29, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jun 29, 2016
|
|
|
Good idea. @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 29, 2016
style: Cleanup `Interpolate` code. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] These changes do not require tests because refactoring. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11924) <!-- Reviewable:end -->
|
|
| this.interpolate(&other, time).unwrap_or(None).and_then(|value| { | ||
| Some(LengthOrPercentageOrAuto::Calc(value)) | ||
| }) | ||
| if let Ok(maybe) = this.interpolate(&other, time) { |
This comment has been minimized.
This comment has been minimized.
Ms2ger
Jun 29, 2016
Contributor
if let Ok(Some(result)) = this.interpolate(&other, time) {(though I'd use a match)
|
Let's take the intermittent failure as an opportunity to address @Ms2ger's nit. |
|
Nit addressed. For the record, the intermittent was #11703. @bors-servo: r=nox,Ms2ger |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 29, 2016
style: Cleanup `Interpolate` code. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] These changes do not require tests because refactoring. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11924) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedJun 29, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is