Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file-type input element #11931

Merged
merged 1 commit into from Jun 30, 2016
Merged

Fix file-type input element #11931

merged 1 commit into from Jun 30, 2016

Conversation

@izgzhen
Copy link
Contributor

izgzhen commented Jun 29, 2016 •
edited

A simple fix to put inputElem.files online

Part of #11131

This change is Reviewable
@highfive
Copy link

highfive commented Jun 29, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/HTMLInputElement.webidl, components/script/dom/htmlinputelement.rs
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jun 29, 2016

r? @Manishearth
@Manishearth
Copy link
Member

Manishearth commented Jun 30, 2016

Oh, I see, you had already added support, but the interface tests didn't pass because the support only worked when you had selected the file. 😄

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

📌 Commit 60e63af has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

⌛ Testing commit 60e63af with merge b1a2618...
bors-servo added a commit that referenced this pull request Jun 30, 2016
@bors-servo
Auto merge of #11931 - izgzhen:fix-html-input-element, r=Manishearth
b1a2618 
Fix file-type input element

A simple fix to put `inputElem.files` online

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11931)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

💔 Test failed - mac-rel-wpt
@Manishearth
Copy link
Member

Manishearth commented Jun 30, 2016

Whole bunch of PASS expected FAILs:


Tests with unexpected results:
  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: attribute files

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: document.createElement("input") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("text") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("hidden") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("search") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("tel") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("url") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("email") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("password") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("date") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("month") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("week") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("time") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("datetime-local") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("number") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("range") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("color") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("checkbox") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("radio") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("submit") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("image") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("reset") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] HTMLInputElement interface: createInput("button") must inherit property "files" with the proper type (9)

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=hidden

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=text

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=search

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=tel

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=url

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=email

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=password

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=datetime

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=date

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=month

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=week

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=time

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=datetime-local

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=number

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=range

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=color

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=checkbox

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=radio

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=submit

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=image

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=reset

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=button

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/files.html:
  └ PASS [expected FAIL] files for input type=file

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/hidden.html:
  └ PASS [expected FAIL] files attribute must return null for hidden

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/text.html:
  └ PASS [expected FAIL] files attribute must return null for text

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/text.html:
  └ PASS [expected FAIL] files attribute must return null for search
@izgzhen
Copy link
Contributor Author

izgzhen commented Jun 30, 2016

Oh, nice, I thought only FileAPI cover that ... I will fix this
@izgzhen izgzhen force-pushed the izgzhen:fix-html-input-element branch from 60e63af to d30bc21 Jun 30, 2016
@izgzhen
Fix file-type input element
Loading status checks…
6ca531f
@izgzhen izgzhen force-pushed the izgzhen:fix-html-input-element branch from d30bc21 to 6ca531f Jun 30, 2016
@izgzhen
Copy link
Contributor Author

izgzhen commented Jun 30, 2016

Done
@Manishearth
Copy link
Member

Manishearth commented Jun 30, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

📌 Commit 6ca531f has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

⌛ Testing commit 6ca531f with merge 8052f5b...
bors-servo added a commit that referenced this pull request Jun 30, 2016
@bors-servo
Auto merge of #11931 - izgzhen:fix-html-input-element, r=Manishearth
Loading status checks…
8052f5b 
Fix file-type input element

A simple fix to put `inputElem.files` online

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11931)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jun 30, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@izgzhen
Copy link
Contributor Author

izgzhen commented Jun 30, 2016

@bors-servo retry

Issue #11574
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 6ca531f into servo:master Jun 30, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@izgzhen @highfive @larsbergstrom @Manishearth @bors-servo
You can’t perform that action at this time.