Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Glutin to pick up borderless window performance fixes on Mac. #11940

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Update Glutin to pick up borderless window performance fixes on Mac.

Large framerate improvement in browser.html.

This takes the Glutin upgrade intended for #11130 but does not address
the underlying issue. A FIXME has been added.
  • Loading branch information
pcwalton committed Jun 30, 2016
commit 10d934523daf0f8f59265e38b76401f404246701

Some generated files are not rendered by default. Learn more.

@@ -81,7 +81,6 @@ fn builder_with_platform_options(mut builder: glutin::WindowBuilder) -> glutin::
builder = builder.with_activation_policy(ActivationPolicy::Prohibited)
}
builder.with_app_name(String::from("Servo"))
.with_transparent_corner_radius(8)
}

#[cfg(not(target_os = "macos"))]
@@ -261,7 +260,8 @@ impl Window {
Event::Resized(width, height) => {
self.event_queue.borrow_mut().push(WindowEvent::Resize(Size2D::typed(width, height)));
}
Event::MouseInput(element_state, mouse_button) => {
Event::MouseInput(element_state, mouse_button, _) => {
// FIXME(#11130, pcwalton): The third field should be used.
if mouse_button == MouseButton::Left ||
mouse_button == MouseButton::Right {
let mouse_pos = self.mouse_pos.get();
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.