Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a script to upload nightly packages to S3 #11943
Merged
Conversation
Closed
|
|
||
| if [[ "${platform}" == "android" ]]; then | ||
| package=target/arm-linux-androideabi/release/*.apk | ||
| elif [[ "${platform}" == "linux" ]]; then |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
Jun 30, 2016
Contributor
Can you also allow "windows" here, until we have a .msi builder in place?
etc/ci/upload_nightly.sh
Outdated
| if [[ "${platform}" == "android" ]]; then | ||
| package=target/arm-linux-androideabi/release/*.apk | ||
| elif [[ "${platform}" == "linux" ]]; then | ||
| package=target/release/*.tar.gz |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
Jun 30, 2016
Contributor
I believe the release is not part of the package path for the tarball packaging, at least on Windows (and I assume linux, as they share the same python).
aneeshusa
force-pushed the
aneeshusa:add-nightly-upload-script
branch
from
9b9e37d
to
6df6f0b
The nightly package name includes the date, and so we use a glob to locate the package file without hard coding a value. However, globbing will not work with our Buildbot steps setup because we perform word splitting ourselves and pass an array to Buildbot, which will directly exec the array instead of passing it to the shell, meaning globbing does not occur. Instead, add a script to the servo repo where we can use globbing, and use `shopt -s failglob` to guard against bad globs.
aneeshusa
force-pushed the
aneeshusa:add-nightly-upload-script
branch
from
6df6f0b
to
9dc9643
|
@bors-servo r+ |
|
|
bors-servo
added a commit
to servo/saltfs
that referenced
this pull request
Jun 30, 2016
…rsbergstrom Add linux and osx nightly builds Alternative to #409 that is more secure IMO. Requires servo/servo#11943. cc @larsbergstrom @edunham <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/410) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Jun 30, 2016
…gstrom Add a script to upload nightly packages to S3 <!-- Please describe your changes on the following line: --> The nightly package name includes the date, and so we use a glob to locate the package file without hard coding a value. However, globbing will not work with our Buildbot steps setup because we perform word splitting ourselves and pass an array to Buildbot, which will directly exec the array instead of passing it to the shell, meaning globbing does not occur. Instead, add a script to the servo repo where we can use globbing, and use `shopt -s failglob` to guard against bad globs. cc @larsbergstrom @edunham --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes are needed for #9921 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because will be tested by buildbot <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11943) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/saltfs
that referenced
this pull request
Jun 30, 2016
…rsbergstrom Add linux and osx nightly builds Alternative to #409 that is more secure IMO. Requires servo/servo#11943. cc @larsbergstrom @edunham <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/410) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedJun 30, 2016
•
edited by larsbergstrom
The nightly package name includes the date, and so we use a glob to
locate the package file without hard coding a value. However, globbing
will not work with our Buildbot steps setup because we perform word
splitting ourselves and pass an array to Buildbot, which will directly
exec the array instead of passing it to the shell, meaning globbing
does not occur. Instead, add a script to the servo repo where we can
use globbing, and use
shopt -s failglobto guard against bad globs.cc @larsbergstrom @edunham
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is