Bump default resolution to 1024x768 #11953

Manishearth · 2016-06-30T11:02:14Z

Still doesn't make github show the sign in button (for that aspect ratio matters, not resolution), but it otherwise is a bit nicer with more space

This change is

larsbergstrom · 2016-06-30T12:17:21Z

There are lots of other places where the 800x600 appears (comments in that file, another place where it's initialized, etc.). I'd want to get all of them (or unify its appearance) if we make this change.

Also, I'm a little worried that this will take a few trial runs through the infra if we're not forcing to 800x600 on the tests, as our xvfb usage on Linux and our macOS login sessions are at resolutions that work for the current numbers of simultaneous tests and window sizes and have had issues with different resolutions in the past.

Manishearth · 2016-06-30T12:31:56Z

@bors-servo try

bors-servo · 2016-06-30T12:31:59Z

⌛ Trying commit ba73a0a with merge c807379...


        Auto merge of #11953 - Manishearth:more-res, r=<try>

Bump default resolution to 1024x768 Still doesn't make github show the sign in button (for that aspect ratio matters, not resolution), but it otherwise is a bit nicer with more space  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11953)

bors-servo · 2016-06-30T13:23:53Z

💔 Test failed - linux-rel

larsbergstrom · 2016-06-30T13:25:54Z

One intermittent, but two viewport-related failures that are likely related to this change:

  ▶ FAIL [expected PASS] /_mozilla/css/viewport_meta.html
  └   → /_mozilla/css/viewport_meta.html 10f2931024e23f69e5f6c12be81a0fc72469c8bd
/_mozilla/css/viewport_rule_ref.html 445da4c1b7810df6dfa6480e70cb6bd3bf474d16
Testing 10f2931024e23f69e5f6c12be81a0fc72469c8bd == 445da4c1b7810df6dfa6480e70cb6bd3bf474d16

  ▶ FAIL [expected PASS] /_mozilla/css/viewport_rule.html
  └   → /_mozilla/css/viewport_rule.html 10f2931024e23f69e5f6c12be81a0fc72469c8bd
/_mozilla/css/viewport_rule_ref.html 445da4c1b7810df6dfa6480e70cb6bd3bf474d16
Testing 10f2931024e23f69e5f6c12be81a0fc72469c8bd == 445da4c1b7810df6dfa6480e70cb6bd3bf474d16

  ▶ CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/change_parentage.html
  │ 
  │ Xlib:  extension "XFree86-VidModeExtension" missing on display ":0".
  │ ERROR:constellation::constellation: Panic: called `Option::unwrap()` on a `None` value
  │ ERROR:constellation::constellation: Backtrace:
  │ frame #0  - 0x00007f36f8e29e2d - backtrace::backtrace::trace::hccde8df28b4db2a2
  │ frame #1  - 0x00007f36f8e29db5 - backtrace::capture::Backtrace::new::h42f95930bb8c5ee8
  │ frame #2  - 0x00007f36f7ffb799 - _<F as alloc..boxed..FnBox<A>>::call_box::ha632f6060b791d65
  │ frame #3  - 0x00007f36f8e20c38 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::he2b22674ad1748f3
  │ frame #4  - 0x00007f36f8f281ec - std::panicking::rust_panic_with_hook::h983af77c1a2e581b
  │ frame #5  - 0x00007f36f8f42801 - std::panicking::begin_panic::he426e15a3766089a
  │ frame #6  - 0x00007f36f8f29a5a - std::panicking::begin_panic_fmt::hdddb415186c241e7
  │ frame #7  - 0x00007f36f8f4279e - rust_begin_unwind
  │ frame #8  - 0x00007f36f8f78d9f - core::panicking::panic_fmt::hf4e16cb7f0d41a25
  │ frame #9  - 0x00007f36f8f79078 - core::panicking::panic::h907815f47e914305
  │ frame #10 - 0x00007f36f7e07eb1 - script::dom::event::Event::new_uninitialized::h05ae188a870e92b9
  │ frame #11 - 0x00007f36f7e0fb2b - script::dom::event::Event::new::h55256c8cbe9ef79e
  │ frame #12 - 0x00007f36f7e57e1c - script::dom::eventtarget::EventTarget::fire_event::h0d5b30039f5820d2
  │ frame #13 - 0x00007f36f807773a - script::task_source::dom_manipulation::DOMManipulationTask::handle_task::h0ea31f97e475cb7a
  │ frame #14 - 0x00007f36f80061b3 - script::script_thread::ScriptThread::handle_msg_from_script::h47e979ae1e7fb676
  │ frame #15 - 0x00007f36f8057d2f - script::script_thread::ScriptThread::handle_msgs::_$u7b$$u7b$closure$u7d$$u7d$::hb50cf7fd97943b65
  │ frame #16 - 0x00007f36f803ef17 - script::script_thread::ScriptThread::handle_msgs::h1e1abab71191c950
  │ frame #17 - 0x00007f36f7ff9e87 - std::panicking::try::call::h5be47e72fadaa801
  │ frame #18 - 0x00007f36f8f4c9fb - __rust_try
  │ frame #19 - 0x00007f36f8f4c99e - __rust_maybe_catch_panic
  │ frame #20 - 0x00007f36f7ffb0fd - _<F as alloc..boxed..FnBox<A>>::call_box::h3450ad306eff0e43
  │ frame #21 - 0x00007f36f8f409c4 - std::sys::thread::Thread::new::thread_start::h9c883b6d445ece46
  │ frame #22 - 0x00007f36f4b72183 - start_thread
  │ frame #23 - 0x00007f36f468937c - clone
  │ frame #24 - 0x0000000000000000 - <unknown>
  │ 
  └ ERROR:constellation::constellation: Pipeline failed in hard-fail mode.  Crashing!

Manishearth · 2016-06-30T13:41:46Z

The aspect ratio changed, fixed the test. r?

larsbergstrom · 2016-06-30T13:45:21Z

@bors-servo r=till

bors-servo · 2016-06-30T13:45:22Z

📌 Commit 414775b has been approved by till

bors-servo · 2016-06-30T14:07:08Z

⌛ Testing commit 414775b with merge ab9ca11...


        Auto merge of #11953 - Manishearth:more-res, r=till

Bump default resolution to 1024x768 Still doesn't make github show the sign in button (for that aspect ratio matters, not resolution), but it otherwise is a bit nicer with more space  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11953)

bors-servo · 2016-06-30T14:54:25Z

💔 Test failed - mac-rel-wpt

highfive · 2016-06-30T14:54:29Z

  ▶ FAIL [expected PASS] /_mozilla/css/viewport_meta.html
  └   → /_mozilla/css/viewport_meta.html 10f2931024e23f69e5f6c12be81a0fc72469c8bd
/_mozilla/css/viewport_rule_ref.html 3517d8f251bba11e4df9b24ad50256c3a8216138
Testing 10f2931024e23f69e5f6c12be81a0fc72469c8bd == 3517d8f251bba11e4df9b24ad50256c3a8216138

  ▶ FAIL [expected PASS] /_mozilla/css/viewport_rule.html
  └   → /_mozilla/css/viewport_rule.html 10f2931024e23f69e5f6c12be81a0fc72469c8bd
/_mozilla/css/viewport_rule_ref.html 3517d8f251bba11e4df9b24ad50256c3a8216138
Testing 10f2931024e23f69e5f6c12be81a0fc72469c8bd == 3517d8f251bba11e4df9b24ad50256c3a8216138

cbrewster · 2016-06-30T14:57:02Z

Would it be possible to keep the tests at 800x600 and have non-test runs use 1024x768?

Manishearth · 2016-06-30T14:58:14Z

Yes.

Manishearth · 2016-06-30T15:43:14Z

I changed this to pin the tests to the old resolution (there's a WPT option). Tests pass now.

I tried to figure out the exact pixel value it needed, but even inputting the clientWidth numbers didn't work. It seems like in the existing test the values don't exactly match either (232 instead of 240?), so I'm not sure what's happening.


        Auto merge of #11953 - Manishearth:more-res, r=till,ms2ger

Bump default resolution to 1024x768 Still doesn't make github show the sign in button (for that aspect ratio matters, not resolution), but it otherwise is a bit nicer with more space  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11953)

bors-servo · 2016-07-01T00:41:46Z

💔 Test failed - mac-rel-wpt

cbrewster · 2016-07-01T00:44:20Z

@bors-servo retry

#11618

metajack · 2016-07-01T00:46:02Z

@bors-servo retry

#11618

asajeffrey · 2016-07-01T00:49:41Z

@bors-servo p=10

bors-servo · 2016-07-01T01:34:09Z

⌛ Testing commit e4d3c74 with merge 48d513a...


        Auto merge of #11953 - Manishearth:more-res, r=till,ms2ger

Bump default resolution to 1024x768 Still doesn't make github show the sign in button (for that aspect ratio matters, not resolution), but it otherwise is a bit nicer with more space  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11953)

bors-servo · 2016-07-01T02:26:46Z

💔 Test failed - linux-rel

highfive · 2016-07-01T02:26:49Z

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728

larsbergstrom · 2016-07-01T02:28:00Z

@bors-servo retry p=10

#11574

bors-servo · 2016-07-01T03:19:24Z

⌛ Testing commit e4d3c74 with merge 99e5b61...


        Auto merge of #11953 - Manishearth:more-res, r=till,ms2ger

Bump default resolution to 1024x768 Still doesn't make github show the sign in button (for that aspect ratio matters, not resolution), but it otherwise is a bit nicer with more space  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11953)


        Auto merge of #12223 - jdm:wptrunnerup, r=Ms2ger

@Manishearth

Upgrade wptrunner This should allow us to start running and writing new webdriver tests. Note, this currently undoes the viewport-related change from #11953. @Manishearth what do you want to do here? --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because our test instrastructure will test it  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12223)


        Auto merge of #12223 - jdm:wptrunnerup, r=<try>

@Manishearth

Upgrade wptrunner This should allow us to start running and writing new webdriver tests. Note, this currently undoes the viewport-related change from #11953. @Manishearth what do you want to do here? --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because our test instrastructure will test it  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12223)


        Auto merge of #12223 - jdm:wptrunnerup, r=<try>

@Manishearth

Upgrade wptrunner This should allow us to start running and writing new webdriver tests. Note, this currently undoes the viewport-related change from #11953. @Manishearth what do you want to do here? --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because our test instrastructure will test it  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12223)


        Auto merge of #12223 - jdm:wptrunnerup, r=<try>

@Manishearth

Upgrade wptrunner This should allow us to start running and writing new webdriver tests. Note, this currently undoes the viewport-related change from #11953. @Manishearth what do you want to do here? --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because our test instrastructure will test it  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12223)


        Auto merge of #12223 - jdm:wptrunnerup, r=<try>

@Manishearth

Upgrade wptrunner This should allow us to start running and writing new webdriver tests. Note, this currently undoes the viewport-related change from #11953. @Manishearth what do you want to do here? --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because our test instrastructure will test it  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12223)

highfive assigned SimonSapin Jun 30, 2016

highfive added the S-awaiting-review label Jun 30, 2016

Manishearth force-pushed the Manishearth:more-res branch 2 times, most recently from 1531740 to ba73a0a Jun 30, 2016

highfive added the S-tests-failed label Jun 30, 2016

Manishearth force-pushed the Manishearth:more-res branch from ba73a0a to 414775b Jun 30, 2016

highfive removed the S-tests-failed label Jun 30, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Jun 30, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 30, 2016

Manishearth force-pushed the Manishearth:more-res branch from 414775b to ae99d88 Jun 30, 2016

highfive added S-awaiting-review and removed S-tests-failed labels Jun 30, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jul 1, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Jul 1, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jul 1, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Jul 1, 2016

larsbergstrom merged commit 5d225d9 into servo:master Jul 1, 2016
1 of 2 checks passed

1 of 2 checks passed

homu Testing commit e4d3c74 with merge 99e5b61...
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

highfive removed the S-awaiting-merge label Jul 1, 2016

jdm mentioned this pull request Jul 4, 2016

Upgrade wptrunner #12223

Closed

3 of 3 tasks complete

Manishearth deleted the Manishearth:more-res branch May 7, 2019

servo / servo

Bump default resolution to 1024x768 #11953

Bump default resolution to 1024x768 #11953

Manishearth commented Jun 30, 2016 •

edited by larsbergstrom

larsbergstrom commented Jun 30, 2016

Manishearth commented Jun 30, 2016

bors-servo commented Jun 30, 2016

bors-servo commented Jun 30, 2016

larsbergstrom commented Jun 30, 2016

Manishearth commented Jun 30, 2016

larsbergstrom commented Jun 30, 2016

bors-servo commented Jun 30, 2016

bors-servo commented Jun 30, 2016

bors-servo commented Jun 30, 2016

highfive commented Jun 30, 2016

cbrewster commented Jun 30, 2016

Manishearth commented Jun 30, 2016

Manishearth commented Jun 30, 2016

bors-servo commented Jul 1, 2016

cbrewster commented Jul 1, 2016

metajack commented Jul 1, 2016

asajeffrey commented Jul 1, 2016

bors-servo commented Jul 1, 2016

bors-servo commented Jul 1, 2016

highfive commented Jul 1, 2016

larsbergstrom commented Jul 1, 2016

bors-servo commented Jul 1, 2016

servo / servo

Join GitHub today

Bump default resolution to 1024x768 #11953

Bump default resolution to 1024x768 #11953

Conversation

Manishearth commented Jun 30, 2016 • edited by larsbergstrom

larsbergstrom commented Jun 30, 2016

Manishearth commented Jun 30, 2016

bors-servo commented Jun 30, 2016

bors-servo commented Jun 30, 2016

larsbergstrom commented Jun 30, 2016

Manishearth commented Jun 30, 2016

larsbergstrom commented Jun 30, 2016

bors-servo commented Jun 30, 2016

bors-servo commented Jun 30, 2016

bors-servo commented Jun 30, 2016

highfive commented Jun 30, 2016

cbrewster commented Jun 30, 2016

Manishearth commented Jun 30, 2016

Manishearth commented Jun 30, 2016

bors-servo commented Jul 1, 2016

cbrewster commented Jul 1, 2016

metajack commented Jul 1, 2016

asajeffrey commented Jul 1, 2016

bors-servo commented Jul 1, 2016

bors-servo commented Jul 1, 2016

highfive commented Jul 1, 2016

larsbergstrom commented Jul 1, 2016

bors-servo commented Jul 1, 2016

Manishearth commented Jun 30, 2016 •

edited by larsbergstrom