Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default resolution to 1024x768 #11953

Merged
merged 1 commit into from Jul 1, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Bump default resolution to 1024x740

  • Loading branch information
Manishearth committed Jun 30, 2016
commit e4d3c74928e54a2d6ef0adf523c15feea6154ce8
@@ -486,7 +486,7 @@ pub fn default_opts() -> Opts {
trace_layout: false,
devtools_port: None,
webdriver_port: None,
initial_window_size: Size2D::typed(800, 600),
initial_window_size: Size2D::typed(1024, 740),
user_agent: default_user_agent_string(DEFAULT_USER_AGENT),
multiprocess: false,
random_pipeline_closure_probability: None,
@@ -543,7 +543,7 @@ pub fn from_cmdline_args(args: &[String]) -> ArgumentParsingResult {
opts.optflag("F", "soft-fail", "Display about:failure on thread failure instead of exiting");
opts.optflagopt("", "devtools", "Start remote devtools server on port", "6000");
opts.optflagopt("", "webdriver", "Start remote WebDriver server on port", "7000");
opts.optopt("", "resolution", "Set window resolution.", "800x600");
opts.optopt("", "resolution", "Set window resolution.", "1024x740");
opts.optopt("u",
"user-agent",
"Set custom user agent string (or android / desktop for platform default)",
@@ -717,7 +717,7 @@ pub fn from_cmdline_args(args: &[String]) -> ArgumentParsingResult {
Size2D::typed(res[0], res[1])
}
None => {
Size2D::typed(800, 600)
Size2D::typed(1024, 740)
}
};

@@ -216,6 +216,8 @@ def screenshot(self, test, viewport_size, dpi):

if viewport_size:
command += ["--resolution", viewport_size]
else:
command += ["--resolution", "800x600"]

if dpi:
command += ["--device-pixel-ratio", dpi]
@@ -5509,7 +5509,8 @@
"=="
]
],
"url": "/_mozilla/css/viewport_meta.html"
"url": "/_mozilla/css/viewport_meta.html",
"viewport_size": "800x600"
}
],
"css/viewport_percentage_vmin_vmax_a.html": [
@@ -5573,7 +5574,8 @@
"=="
]
],
"url": "/_mozilla/css/viewport_rule.html"
"url": "/_mozilla/css/viewport_rule.html",
"viewport_size": "800x600"
}
],
"css/visibility_hidden.html": [
@@ -12609,7 +12611,8 @@
"=="
]
],
"url": "/_mozilla/css/viewport_meta.html"
"url": "/_mozilla/css/viewport_meta.html",
"viewport_size": "800x600"
}
],
"css/viewport_percentage_vmin_vmax_a.html": [
@@ -12673,7 +12676,8 @@
"=="
]
],
"url": "/_mozilla/css/viewport_rule.html"
"url": "/_mozilla/css/viewport_rule.html",
"viewport_size": "800x600"
}
],
"css/visibility_hidden.html": [
@@ -2,6 +2,7 @@
<html>
<head>
<link rel=match href=viewport_rule_ref.html>
<meta name=viewport-size content=800x600>
<meta name="viewport" content="width=240">
<style>
#container {
@@ -2,6 +2,7 @@
<html>
<head>
<link rel=match href=viewport_rule_ref.html>
<meta name=viewport-size content=800x600>
<style>
@viewport {
height: auto;
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.