Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange servo s3 build bucket name #11959
Merged
Conversation
highfive
commented
Jun 30, 2016
|
Heads up! This PR modifies the following files:
|
|
@bors-servo r+ Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 30, 2016
Change servo s3 build bucket name <!-- Please describe your changes on the following line: --> This will allow us to push to URLs like: http://servo-builds.s3.amazonaws.com/nightly/mac instead of: http://servo-developer-preview.s3.amazonaws.com/nightly/mac We can have different directories for channels, individual releases, etc. r? @edunham @metajack cc @tschneidereit --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11959) <!-- Reviewable:end -->
|
|
highfive
commented
Jun 30, 2016
|
|
@bors-servo retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedJun 30, 2016
•
edited
This will allow us to push to URLs like:
http://servo-builds.s3.amazonaws.com/nightly/mac
instead of:
http://servo-developer-preview.s3.amazonaws.com/nightly/mac
We can have different directories for channels, individual releases, etc.
r? @edunham @metajack
cc @tschneidereit
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is