Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staticize CASCADE_PROPERTIES, (temporarily) fix stylo path for animations, and introduce the long-term path to follow #11972

Merged
merged 5 commits into from Jul 3, 2016
Merged

Staticize CASCADE_PROPERTIES, (temporarily) fix stylo path for animations, and introduce the long-term path to follow #11972

merged 5 commits into from Jul 3, 2016

Commits on Jun 30, 2016

  1. style: Make CASCADE_PROPERTY a real static array. 

    Why wasn't this done before?
    @emilio
    emilio committed Jun 30, 2016
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    2faaf95

Commits on Jul 1, 2016

  1. style: Add a temporary workaround for geckolib animations. 

    With needs_borrow we will be able to remove this, though we'll have to implement
clone_ and borrow_ methods for a bunch of properties.
    @emilio
    emilio committed Jul 1, 2016
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    bc4e670

  2. style: Simplify generation of need_clone methods in servo

    @emilio
    emilio committed Jul 1, 2016
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    07da4e4

  3. style: Add a generic way to deal with lists of values, ditch all uses… 

    … of as_servo in style/animations.rs
    @emilio
    emilio committed Jul 1, 2016
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    ba53c4e

  4. style: remove is_servo(), as_servo() and as_servo_mut() 

    This commit adds a need_index prop to the style system, and autogenerates
iterators, and a get_xxx_mod(i) function from a get_xxx_prop() and
get_xxx_at(index) functions.

This allows us to (finally!) take rid of the as_servo() hack. There are a few
unimplemented clones, but I'm just too lazy for that right now.
    @emilio
    emilio committed Jul 1, 2016
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    30963dd
You can’t perform that action at this time.