Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR for demo fixes. #11973

Merged
merged 1 commit into from Jul 1, 2016
Merged

Update WR for demo fixes. #11973

merged 1 commit into from Jul 1, 2016

Conversation

@glennw
Copy link
Member

glennw commented Jun 30, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@gw3583
Update WR for demo fixes.
Loading status checks…
d2b88e0
@cbrewster
Copy link
Member

cbrewster commented Jun 30, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

📌 Commit d2b88e0 has been approved by ConnorGBrewster
@highfive highfive assigned cbrewster and unassigned jdm Jun 30, 2016
@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 30, 2016

@bors-servo force
1 similar comment
@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 30, 2016

@bors-servo force
@edunham
Copy link
Contributor

edunham commented Jun 30, 2016

@bors-servo retry force
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

⌛ Testing commit d2b88e0 with merge 8519311...
bors-servo added a commit that referenced this pull request Jul 1, 2016
@bors-servo
Auto merge of #11973 - glennw:demo-fix, r=ConnorGBrewster
Loading status checks…
8519311 
Update WR for demo fixes.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11973)
<!-- Reviewable:end -->
@glennw glennw mentioned this pull request Jul 1, 2016
Closed
4 of 4 tasks complete
@metajack
Copy link
Contributor

metajack commented Jul 1, 2016

@bors-servo p=10
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit d2b88e0 into servo:master Jul 1, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@glennw glennw deleted the glennw:demo-fix branch Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cbrewster cbrewster

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
@glennw @cbrewster @bors-servo @mbrubeck @edunham @metajack @jdm @highfive @gw3583
You can’t perform that action at this time.