Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOverwrite the last servo-latest.ext with current file #11989
Closed
Conversation
highfive
commented
Jul 1, 2016
|
Heads up! This PR modifies the following files:
|
| @@ -13,6 +13,7 @@ usage() { | |||
|
|
|||
| upload() { | |||
| s3cmd put "${2}" "s3://servo-builds/nightly/${1}/" | |||
| s3cmd put "${2}" "s3://servo-builds/nightly/${1}/servo-latest${3}" | |||
This comment has been minimized.
This comment has been minimized.
aneeshusa
Jul 1, 2016
•
Member
nit: don't have the ${ext} variables include the period but write "servo-latest.${3}"
| platform="${1}" | ||
|
|
||
| if [[ "${platform}" == "android" ]]; then | ||
| package=target/arm-linux-androideabi/release/*.apk | ||
| ext=".apk" |
This comment has been minimized.
This comment has been minimized.
aneeshusa
Jul 1, 2016
Member
Put the ext= lines above the package= lines, and use the ext variable to keep the extension in sync (i.e. when we have .msi for windows).
|
@larsbergstrom thanks for catching the dup; #12004 looks like a more robust and higher quality script than I threw together last night :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edunham commentedJul 1, 2016
•
edited by larsbergstrom
So we kinda changed the naming scheme at the last minute and this PR will make it so we actually upload packages to the location (servo-latest.ext) that we're telling people to download them from.
If none of this makes any sense, please ping me in the morning and I'll fix it all up and be mildly embarrassed :)
./mach build -ddoes not report any errors/etc/ci is unrelated to the build
./mach test-tidydoes not report any errorsIt's all mad about some wpt stuff I never touched
IRC conversation
This change is