Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite the last servo-latest.ext with current file #11989

Closed
wants to merge 1 commit into from

Conversation

@edunham
Copy link
Contributor

edunham commented Jul 1, 2016

So we kinda changed the naming scheme at the last minute and this PR will make it so we actually upload packages to the location (servo-latest.ext) that we're telling people to download them from.

If none of this makes any sense, please ping me in the morning and I'll fix it all up and be mildly embarrassed :)


  • ./mach build -d does not report any errors
    /etc/ci is unrelated to the build
  • ./mach test-tidy does not report any errors
    It's all mad about some wpt stuff I never touched
  • These changes fix #__ (github issue number if applicable).
    IRC conversation
  • There are tests for these changes OR
  • These changes do not require tests because I hope someone fluent in bash takes a look and tells me if they're bad

This change is Reviewable

@highfive
Copy link

highfive commented Jul 1, 2016

Heads up! This PR modifies the following files:

@@ -13,6 +13,7 @@ usage() {

upload() {
s3cmd put "${2}" "s3://servo-builds/nightly/${1}/"
s3cmd put "${2}" "s3://servo-builds/nightly/${1}/servo-latest${3}"

This comment has been minimized.

@aneeshusa

aneeshusa Jul 1, 2016

Member

nit: don't have the ${ext} variables include the period but write "servo-latest.${3}"

platform="${1}"

if [[ "${platform}" == "android" ]]; then
package=target/arm-linux-androideabi/release/*.apk
ext=".apk"

This comment has been minimized.

@aneeshusa

aneeshusa Jul 1, 2016

Member

Put the ext= lines above the package= lines, and use the ext variable to keep the extension in sync (i.e. when we have .msi for windows).

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 1, 2016

@edunham do you mind if we close this in favor of #12004 from a contributor?

@edunham edunham closed this Jul 1, 2016
@edunham
Copy link
Contributor Author

edunham commented Jul 1, 2016

@larsbergstrom thanks for catching the dup; #12004 looks like a more robust and higher quality script than I threw together last night :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.