Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder code in KeyframesAnimation::from_keyframes() to avoid a panic. #12008

Merged
merged 1 commit into from Jul 1, 2016
Merged

Reorder code in KeyframesAnimation::from_keyframes() to avoid a panic. #12008

merged 1 commit into from Jul 1, 2016
+25 −1

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 1, 2016 •
edited by larsbergstrom

Fixes #11999.
Fixes #12006.

This change is Reviewable
@highfive
Copy link

highfive commented Jul 1, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/keyframes.rs
@highfive
Copy link

highfive commented Jul 1, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Ms2ger
Reorder code in KeyframesAnimation::from_keyframes() to avoid a panic.
Loading status checks…
70e964b 
Fixes #11999.
Fixes #12006.
@Ms2ger Ms2ger force-pushed the keyframes branch from c4aaeda to 70e964b Jul 1, 2016
@Manishearth
Copy link
Member

Manishearth commented Jul 1, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

📌 Commit 70e964b has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned mbrubeck Jul 1, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

⌛ Testing commit 70e964b with merge 5a18f91...
bors-servo added a commit that referenced this pull request Jul 1, 2016
@bors-servo
Auto merge of #12008 - servo:keyframes, r=Manishearth
5a18f91 
Reorder code in KeyframesAnimation::from_keyframes() to avoid a panic.

Fixes #11999.
Fixes #12006.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12008)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

💔 Test failed - linux-rel
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jul 1, 2016

@bors-servo retry #11825
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

⌛ Testing commit 70e964b with merge b2a32ec...
bors-servo added a commit that referenced this pull request Jul 1, 2016
@bors-servo
Auto merge of #12008 - servo:keyframes, r=Manishearth
Loading status checks…
b2a32ec 
Reorder code in KeyframesAnimation::from_keyframes() to avoid a panic.

Fixes #11999.
Fixes #12006.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12008)
<!-- Reviewable:end -->
This was referenced Jul 1, 2016
Closed
Closed
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 70e964b into master Jul 1, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio

This comment has been minimized.

Sign in to view
Copy link
Member

emilio commented on 70e964b Jul 1, 2016

Whoops...
@Ms2ger Ms2ger mentioned this pull request Jul 2, 2016
Closed
@SimonSapin SimonSapin deleted the keyframes branch Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @Manishearth @bors-servo @emilio @mbrubeck
You can’t perform that action at this time.