Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a faster Brotli crate #12050

Merged
merged 1 commit into from Jul 4, 2016
Merged

Switch to a faster Brotli crate #12050

merged 1 commit into from Jul 4, 2016

Conversation

@johannhof
Copy link
Contributor

johannhof commented Jul 1, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #11933.
  • These changes do not require tests (I hope) because no new behavior was introduced

This change is Reviewable
@highfive
Copy link

highfive commented Jul 1, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @KiChjang (or someone else) soon.
@highfive
Copy link

highfive commented Jul 1, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/Cargo.toml, components/net/http_loader.rs
@highfive
Copy link

highfive commented Jul 1, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jul 1, 2016

There's an automated test at https://dxr.mozilla.org/servo/source/tests/wpt/mozilla/tests/mozilla/response-data-brotli.htm so we should be good to go.
@jdm
Copy link
Member

jdm commented Jul 1, 2016

@bors-servo: r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

📌 Commit bf61d45 has been approved by jdm
@highfive highfive assigned jdm and unassigned KiChjang Jul 1, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

⌛ Testing commit bf61d45 with merge a06317d...
bors-servo added a commit that referenced this pull request Jul 1, 2016
@bors-servo
Auto merge of #12050 - johannhof:brotli, r=jdm
a06317d 
Switch to a faster Brotli crate

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11933.

<!-- Either: -->
- [x] These changes do not require tests (I hope) because no new behavior was introduced

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12050)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

💔 Test failed - linux-dev
@cbrewster
Copy link
Member

cbrewster commented Jul 1, 2016

Could you run ./mach cargo-update -p brotli to change the other locations in the lockfiles? (The CEF ones did not get updated)
@johannhof
Switch to a faster Brotli crate
Unverified
This user has not uploaded their public key yet.
GPG key ID: 15DD943556C9CC16 Learn about signing commits
Loading status checks…
7890440
@johannhof johannhof force-pushed the johannhof:brotli branch from bf61d45 to 7890440 Jul 1, 2016
@johannhof
Copy link
Contributor Author

johannhof commented Jul 1, 2016

Oh, yes, I missed that one. Updated! Thanks!
@cbrewster
Copy link
Member

cbrewster commented Jul 1, 2016

@johannhof no problem, thanks for doing this!
@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

📌 Commit 7890440 has been approved by jdm
bors-servo added a commit that referenced this pull request Jul 1, 2016
@bors-servo
Auto merge of #12050 - johannhof:brotli, r=jdm
882081f 
Switch to a faster Brotli crate

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11933.

<!-- Either: -->
- [x] These changes do not require tests (I hope) because no new behavior was introduced

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12050)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

⌛ Testing commit 7890440 with merge 882081f...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jul 1, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@cbrewster
Copy link
Member

cbrewster commented Jul 1, 2016

@bors-servo retry
@frewsxcv frewsxcv closed this Jul 2, 2016
@frewsxcv frewsxcv reopened this Jul 2, 2016
@frewsxcv
Copy link
Member

frewsxcv commented Jul 2, 2016

@bors-servo retry
@nox
Copy link
Member

nox commented Jul 2, 2016

@bors-servo force
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 4, 2016

@bors-servo retry

#11574
@bors-servo
Copy link
Contributor

bors-servo commented Jul 4, 2016

⌛ Testing commit 7890440 with merge c8b048e...
bors-servo added a commit that referenced this pull request Jul 4, 2016
@bors-servo
Auto merge of #12050 - johannhof:brotli, r=jdm
Loading status checks…
c8b048e 
Switch to a faster Brotli crate

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11933.

<!-- Either: -->
- [x] These changes do not require tests (I hope) because no new behavior was introduced

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12050)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 4, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 7890440 into servo:master Jul 4, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Switch to Dropbox's crate for Brotli encoding/decoding
9 participants
@johannhof @highfive @jdm @bors-servo @cbrewster @frewsxcv @nox @larsbergstrom @KiChjang
You can’t perform that action at this time.