Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a spec-incompliant load event. #1213
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
kmcallister
commented on src/test/html/content/test_load_event.html in 3b3f891
Nov 11, 2013
|
If the event doesn't fire at all, the test will fail by timeout? |
This comment has been minimized.
This comment has been minimized.
|
Yes. |
This comment has been minimized.
This comment has been minimized.
kmcallister
commented on 3b3f891
Nov 12, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from kmcallister |
This comment has been minimized.
This comment has been minimized.
|
merging jdm/servo/loadevent = 3b3f891 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = da4ca51 |
bors-servo
pushed a commit
that referenced
this pull request
Nov 12, 2013
bors-servo
merged commit 3b3f891
into
servo:master
1 check passed
1 check passed
default
all tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedNov 11, 2013
It's good enough for now, since we don't track document resources at all. Should be good enough for #841.