Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake etc/ci/upload_nightly.sh responsible for putting datetimes into filenames #12163
Conversation
highfive
commented
Jul 2, 2016
|
Heads up! This PR modifies the following files:
|
534fea9
to
4d966ee
|
|
|
This should also incorporate the change in #12088/wait for that to merge. |
| upload() { | ||
| local package_filename | ||
| local package_filename current_date_time |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aneeshusa
Jul 3, 2016
Member
Also rename package_filename to nightly_filename since it'll include the timestamp per my other comment.
| package_filename="$(basename "${2}")" | ||
| current_date_time="$(date -u +"%Y-%m-%dT%H:%M:%SZ")" |
This comment has been minimized.
This comment has been minimized.
aneeshusa
Jul 3, 2016
Member
Put this line before the one that sets package_filename, and then include nightly_timestamp when you set package_filename.
…loadnightlysh-responsible-date-times Conflicts: etc/ci/upload_nightly.sh
|
@aneeshusa Resolve the merge conflict and review comments, just need to wait on #12088 landing. Is #12088 still relevant in that file if this PR moves the time/date logic into |
|
|
|
Well, it just merged, so that's a moot point now :) That PR changes the colons in the timestamp to dashes because the |
|
@aneeshusa I will port the functionality from the Python into |
|
#12088 merged so this is no longer blocked. @imjacobclark are you still working on this? Do you have any questions? |
|
@aneeshusa still working on this, had a bit of a hectic few weeks, however will pick this up again now. Pretty straightforward, I'll catch up on IRC if there are any issues. |
|
@imjacobclark Is this still being worked on? |
|
I'd like to help finish this one if it's up for grabs. It looks like the datetime got moved to the upload_nightly.sh but still uses colons. |
|
@rjgoldsborough Yes, please feel free to submit a PR for this! This needs a rebase, but if you look at |
|
Closing based on inactivity (@rjgoldsborough has started working on it in #14058) |
imjacobclark commentedJul 2, 2016
•
edited
This is part of #11980, allowing for more reproducible builds, increasing the security and integrity of the release process.
This particular change ensures the date and time is on the files that are available for download from the nightly-release s3 bucket and removes that responsibility from the packager.
See #12128 for more details.
@aneeshusa
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is