Make etc/ci/upload_nightly.sh responsible for putting datetimes into filenames#12163
Make etc/ci/upload_nightly.sh responsible for putting datetimes into filenames#12163imjacobclark wants to merge 5 commits intoservo:masterfrom
Conversation
|
Heads up! This PR modifies the following files:
|
534fea9 to
4d966ee
Compare
|
☔ The latest upstream changes (presumably #12156) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This should also incorporate the change in #12088/wait for that to merge. |
etc/ci/upload_nightly.sh
Outdated
|
|
||
| upload() { | ||
| local package_filename | ||
| local package_filename current_date_time |
There was a problem hiding this comment.
Let's rename current_date_time to nightly_timestamp.
There was a problem hiding this comment.
Also rename package_filename to nightly_filename since it'll include the timestamp per my other comment.
…loadnightlysh-responsible-date-times Conflicts: etc/ci/upload_nightly.sh
|
@aneeshusa Resolve the merge conflict and review comments, just need to wait on #12088 landing. Is #12088 still relevant in that file if this PR moves the time/date logic into |
|
☔ The latest upstream changes (presumably #12088) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Well, it just merged, so that's a moot point now :) That PR changes the colons in the timestamp to dashes because the |
|
@aneeshusa I will port the functionality from the Python into |
|
#12088 merged so this is no longer blocked. @imjacobclark are you still working on this? Do you have any questions? |
|
@aneeshusa still working on this, had a bit of a hectic few weeks, however will pick this up again now. Pretty straightforward, I'll catch up on IRC if there are any issues. |
|
@imjacobclark Is this still being worked on? |
|
I'd like to help finish this one if it's up for grabs. It looks like the datetime got moved to the upload_nightly.sh but still uses colons. |
|
@rjgoldsborough Yes, please feel free to submit a PR for this! This needs a rebase, but if you look at |
|
Closing based on inactivity (@rjgoldsborough has started working on it in #14058) |
This is part of #11980, allowing for more reproducible builds, increasing the security and integrity of the release process.
This particular change ensures the date and time is on the files that are available for download from the nightly-release s3 bucket and removes that responsibility from the packager.
See #12128 for more details.
@aneeshusa
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is