Implement video-metadata check #12186

GuillaumeGomez · 2016-07-02T21:53:19Z

This change is

highfive · 2016-07-02T21:53:22Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/lib.rs, components/script/Cargo.toml, components/script/dom/htmlmediaelement.rs

highfive · 2016-07-02T21:53:23Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

GuillaumeGomez · 2016-07-02T21:53:25Z

r? @jdm

GuillaumeGomez · 2016-07-02T21:53:58Z

components/script/dom/htmlmediaelement.rs

@@ -167,6 +181,16 @@ impl HTMLMediaElementContext {
 }

 #[dom_struct]
+pub struct VideoMedia {


The error happens here.

GuillaumeGomez · 2016-07-02T23:39:59Z

I now need to add libraries for tests and build. Anywhere I could start to look at?

emilio · 2016-07-03T02:12:34Z

For travis, adding the corresponding -dev sources to APT should work. For homu, you probably need to get a PR merged in servo/saltfs.

emilio · 2016-07-03T02:13:18Z

I'd like to review the new dependency carefully, since it seems it contains kind-of-sensible FFI code.

emilio · 2016-07-03T02:14:52Z

Oh, and also, please update the dependency section at the README.
Thanks btw! :)

emilio · 2016-07-03T02:31:56Z

Yeah, I'm reviewing the dependency right now, @GuillaumeGomez, would you accept some patches? :)

GuillaumeGomez · 2016-07-03T10:03:34Z

For travis, adding the corresponding -dev sources to APT should work. For homu, you probably need to get a PR merged in servo/saltfs.

I'm using version 3.x of libraries and travis only provides 2.x (like every other linux package managers as it seems).

Yeah, I'm reviewing the dependency right now, @GuillaumeGomez, would you accept some patches? :)

I would very gladly! :)

nox · 2016-07-03T11:56:46Z

You probably need to run ./mach cargo-update -p script, btw.

izgzhen · 2016-07-04T02:26:06Z

components/script/dom/htmlmediaelement.rs

@@ -166,6 +180,19 @@ impl HTMLMediaElementContext {
    }
 }

+no_jsmanaged_fields!(Duration);


Adding this to script/dom/bindings/trace.rs would be easier to maintain ;)

GuillaumeGomez · 2016-07-05T09:25:15Z

#11882

notriddle · 2016-07-05T14:51:12Z

Could you squash all the commits down into one?

notriddle · 2016-07-05T15:08:34Z

components/script/dom/htmlmediaelement.rs, line 110 [r1] (raw file):

            // Step 6
            elem.change_ready_state(HAVE_METADATA);
            self.have_metadata = true;

If we only got a partial video header, get_format_from_slice will fail, elem.video will be None, but have_metadata will still be set. Then we'll get the rest of it, but we won't parse it.

Comments from Reviewable

GuillaumeGomez · 2016-07-05T15:12:07Z

Review status: 0 of 8 files reviewed at latest revision, 3 unresolved discussions.

components/script/dom/htmlmediaelement.rs, line 110 [r1] (raw file):

Previously, notriddle (Michael Howell) wrote…

If we only got a partial video header, get_format_from_slice will fail, elem.video will be None, but have_metadata will still be set. Then we'll get the rest of it, but we won't parse it.

Done.

Comments from Reviewable

notriddle · 2016-07-05T15:22:48Z

a discussion (no related file):
That leaves us with only two problems:

We need the dependencies on the buildslaves.
We need Servo-level tests. WPT might already have some: I'll run bors try as soon as possible.

Comments from Reviewable

notriddle · 2016-07-05T15:22:53Z

Reviewed 4 of 4 files at r1, 1 of 1 files at r2, 6 of 6 files at r3, 1 of 1 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

GuillaumeGomez · 2016-07-05T15:30:05Z

I splitted changes in their own commits like asked.

Review status: 6 of 8 files reviewed at latest revision, 2 unresolved discussions.

a discussion (no related file):

Previously, notriddle (Michael Howell) wrote…

That leaves us with only two problems:

We need the dependencies on the buildslaves.

We need Servo-level tests. WPT might already have some: I'll run bors try as soon as possible.

How can I add the dependencies on the buildslaves?

Comments from Reviewable

notriddle · 2016-07-05T15:32:26Z

Reviewed 2 of 2 files at r6, 2 of 2 files at r7.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

a discussion (no related file):

Previously, GuillaumeGomez (Guillaume Gomez) wrote…

How can I add the dependencies on the buildslaves?

You'll need to make a pull request to [servo/saltfs](https://github.com/servo/saltfs).

Comments from Reviewable

KiChjang · 2016-07-29T21:48:48Z

@bors-servo r-

KiChjang · 2016-07-29T22:00:40Z

@bors-servo r=larsbergstrom,jdm,KiChjang

bors-servo · 2016-07-29T22:00:41Z

📌 Commit e1bf3c1 has been approved by larsbergstrom,jdm,KiChjang


        Auto merge of #12186 - GuillaumeGomez:video-metadata, r=larsbergstrom…

…,jdm,KiChjang Implement video-metadata check  This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12186)

bors-servo · 2016-07-29T22:00:44Z

⌛ Testing commit e1bf3c1 with merge 5be08b7...


        Change tests results to set timeout/failure expected

KiChjang · 2016-07-29T22:46:40Z

@bors-servo r=larsbergstrom,jdm,KiChjang

bors-servo · 2016-07-29T22:46:41Z

📌 Commit 34cb551 has been approved by larsbergstrom,jdm,KiChjang

bors-servo · 2016-07-29T22:46:43Z

⌛ Testing commit 34cb551 with merge d053fb1...


        Auto merge of #12186 - GuillaumeGomez:video-metadata, r=larsbergstrom…

…,jdm,KiChjang Implement video-metadata check  This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12186)

bors-servo · 2016-07-29T23:45:07Z

💔 Test failed - mac-rel-wpt

larsbergstrom · 2016-07-29T23:46:40Z

@bors-servo retry

#12592

bors-servo · 2016-07-29T23:46:43Z

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

bors-servo · 2016-07-30T00:50:38Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev


        Auto merge of #12734 - servo:jdm-patch-1, r=ConnorGBrewster

Update mac prerequisites for libavformat requirements These were missed in #12186.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12734)

highfive assigned larsbergstrom Jul 2, 2016

highfive added the S-awaiting-review label Jul 2, 2016

highfive assigned jdm and unassigned larsbergstrom Jul 2, 2016

GuillaumeGomez reviewed Jul 2, 2016
View changes

components/script/dom/htmlmediaelement.rs Outdated

@@ -167,6 +181,16 @@ impl HTMLMediaElementContext {

}

#[dom_struct]

pub struct VideoMedia {

This comment has been minimized.

Sign in to view

Copy link

GuillaumeGomez Jul 2, 2016
Author Contributor

The error happens here.

emilio mentioned this pull request Jul 3, 2016

Rewrite the library to improve safety and prevent extra allocations. GuillaumeGomez/video-metadata-rs#12

Merged

izgzhen reviewed Jul 4, 2016
View changes

notriddle assigned notriddle and unassigned jdm Jul 4, 2016

jdm added S-blocked-on-external and removed S-awaiting-review labels Jul 5, 2016

GuillaumeGomez mentioned this pull request Jul 5, 2016

Add video-metadata-rs dependencies servo/saltfs#428

Merged

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 29, 2016

highfive assigned larsbergstrom and unassigned jdm Jul 29, 2016

highfive added S-awaiting-review and removed S-awaiting-merge labels Jul 29, 2016

Change tests results to set timeout/failure expected

Loading status checks…

34cb551

highfive added S-awaiting-merge and removed S-awaiting-review labels Jul 29, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jul 29, 2016

bors-servo merged commit 34cb551 into servo:master Jul 30, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

GuillaumeGomez deleted the GuillaumeGomez:video-metadata branch Jul 30, 2016

nox mentioned this pull request Jul 31, 2016

Make mach warn when running tests against an old build #12670

Open

jdm mentioned this pull request Aug 4, 2016

Update mac prerequisites for libavformat requirements #12734

Merged

jdm mentioned this pull request Aug 24, 2016

Integrate mp4parse #13024

Closed

servo / servo

Implement video-metadata check #12186

Implement video-metadata check #12186

GuillaumeGomez commented Jul 2, 2016 •

edited by larsbergstrom

highfive commented Jul 2, 2016

highfive commented Jul 2, 2016

GuillaumeGomez commented Jul 2, 2016

This comment has been minimized.

GuillaumeGomez commented Jul 2, 2016

emilio commented Jul 3, 2016

emilio commented Jul 3, 2016

emilio commented Jul 3, 2016

emilio commented Jul 3, 2016

GuillaumeGomez commented Jul 3, 2016

nox commented Jul 3, 2016

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Jul 5, 2016

notriddle commented Jul 5, 2016 •

edited

notriddle commented Jul 5, 2016

GuillaumeGomez commented Jul 5, 2016

notriddle commented Jul 5, 2016

notriddle commented Jul 5, 2016

GuillaumeGomez commented Jul 5, 2016

notriddle commented Jul 5, 2016

KiChjang commented Jul 29, 2016

KiChjang commented Jul 29, 2016

bors-servo commented Jul 29, 2016

bors-servo commented Jul 29, 2016

KiChjang commented Jul 29, 2016

bors-servo commented Jul 29, 2016

bors-servo commented Jul 29, 2016

bors-servo commented Jul 29, 2016

larsbergstrom commented Jul 29, 2016

bors-servo commented Jul 29, 2016

bors-servo commented Jul 30, 2016

servo / servo

Join GitHub today

Implement video-metadata check #12186

Implement video-metadata check #12186

Conversation

GuillaumeGomez commented Jul 2, 2016 • edited by larsbergstrom

highfive commented Jul 2, 2016

highfive commented Jul 2, 2016

GuillaumeGomez commented Jul 2, 2016

This comment has been minimized.

GuillaumeGomez Jul 2, 2016

GuillaumeGomez commented Jul 2, 2016

emilio commented Jul 3, 2016

emilio commented Jul 3, 2016

emilio commented Jul 3, 2016

emilio commented Jul 3, 2016

GuillaumeGomez commented Jul 3, 2016

nox commented Jul 3, 2016

This comment has been minimized.

izgzhen Jul 4, 2016

This comment has been minimized.

GuillaumeGomez Jul 4, 2016

GuillaumeGomez commented Jul 5, 2016

notriddle commented Jul 5, 2016 • edited

notriddle commented Jul 5, 2016

GuillaumeGomez commented Jul 5, 2016

notriddle commented Jul 5, 2016

notriddle commented Jul 5, 2016

GuillaumeGomez commented Jul 5, 2016

notriddle commented Jul 5, 2016

KiChjang commented Jul 29, 2016

KiChjang commented Jul 29, 2016

bors-servo commented Jul 29, 2016

bors-servo commented Jul 29, 2016

KiChjang commented Jul 29, 2016

bors-servo commented Jul 29, 2016

bors-servo commented Jul 29, 2016

bors-servo commented Jul 29, 2016

larsbergstrom commented Jul 29, 2016

bors-servo commented Jul 29, 2016

bors-servo commented Jul 30, 2016

GuillaumeGomez commented Jul 2, 2016 •

edited by larsbergstrom

notriddle commented Jul 5, 2016 •

edited