Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit change event when files are selected #12196

Merged
merged 1 commit into from Jul 4, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -1150,13 +1150,15 @@ impl Activatable for HTMLInputElement {
EventCancelable::NotCancelable);
},
InputType::InputFile => {
// https://html.spec.whatwg.org/multipage/#file-upload-state-(type=file)
let window = window_from_node(self);
let filemanager = window.resource_threads().sender();

let mut files: Vec<Root<File>> = vec![];
let mut error = None;

let filter = filter_from_accept(&self.Accept());
let target = self.upcast::<EventTarget>();

if self.Multiple() {
let (chan, recv) = ipc::channel().expect("Error initializing channel");
@@ -1168,6 +1170,13 @@ impl Activatable for HTMLInputElement {
for selected in selected_files {
files.push(File::new_from_selected(window.r(), selected));
}

target.fire_event("input",
EventBubbles::Bubbles,
EventCancelable::NotCancelable);
target.fire_event("change",
EventBubbles::Bubbles,
EventCancelable::NotCancelable);
},
Err(err) => error = Some(err),
};
@@ -1177,7 +1186,16 @@ impl Activatable for HTMLInputElement {
let _ = filemanager.send(msg).unwrap();

match recv.recv().expect("IpcSender side error") {
Ok(selected) => files.push(File::new_from_selected(window.r(), selected)),
Ok(selected) => {
files.push(File::new_from_selected(window.r(), selected));

target.fire_event("input",
EventBubbles::Bubbles,
EventCancelable::NotCancelable);
target.fire_event("change",
EventBubbles::Bubbles,
EventCancelable::NotCancelable);
},
Err(err) => error = Some(err),
};
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.