Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue loading font-face sources on missing local font #12208

Merged
merged 1 commit into from Jul 6, 2016
Merged

Continue loading font-face sources on missing local font #12208

merged 1 commit into from Jul 6, 2016

Conversation

@nox
Copy link
Member

nox commented Jul 4, 2016 •
edited by larsbergstrom

This change is Reviewable
@nox
Continue loading font-face sources on missing local font
Loading status checks…
74a4d76
@highfive
Copy link

highfive commented Jul 4, 2016

warning Warning warning

  • These commits modify gfx code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Jul 4, 2016

This should fix font issues on every website using the Google CDN for fonts, given it lists local sources first, and then url() ones.
@nox nox mentioned this pull request Jul 4, 2016
Closed
@metajack
Copy link
Contributor

metajack commented Jul 5, 2016

@bors-servo r+

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

components/gfx/font_cache_thread.rs, line 272 [r1] (raw file):

                let templates = &mut self.web_families.get_mut(&family_name).unwrap();
                let mut found = false;
                for_each_variation(&font_face_name, |path| {

Was this written before iterators were a thing? Maybe file an E-Easy bug for changing this to for path in font_face_name.variants() or something.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

📌 Commit 74a4d76 has been approved by metajack
@highfive highfive assigned metajack and unassigned asajeffrey Jul 5, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

⌛ Testing commit 74a4d76 with merge ed36fe1...
bors-servo added a commit that referenced this pull request Jul 5, 2016
@bors-servo
Auto merge of #12208 - nox:fontloading, r=metajack
ed36fe1 
Continue loading font-face sources on missing local font

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12208)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member Author

nox commented Jul 5, 2016

@bors-servo retry #11574 #11703
@nox nox added S-awaiting-merge and removed S-tests-failed labels Jul 5, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

⌛ Testing commit 74a4d76 with merge fdb0683...
bors-servo added a commit that referenced this pull request Jul 5, 2016
@bors-servo
Auto merge of #12208 - nox:fontloading, r=metajack
fdb0683 
Continue loading font-face sources on missing local font

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12208)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Jul 6, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

⌛ Testing commit 74a4d76 with merge 53775a1...
bors-servo added a commit that referenced this pull request Jul 6, 2016
@bors-servo
Auto merge of #12208 - nox:fontloading, r=metajack
53775a1 
Continue loading font-face sources on missing local font

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12208)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

⌛ Testing commit 74a4d76 with merge 1642cc5...
bors-servo added a commit that referenced this pull request Jul 6, 2016
@bors-servo
Auto merge of #12208 - nox:fontloading, r=metajack
1642cc5 
Continue loading font-face sources on missing local font

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12208)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member Author

nox commented Jul 6, 2016

@bors-servo retry #11703
@nox nox added S-awaiting-merge and removed S-tests-failed labels Jul 6, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member Author

nox commented Jul 6, 2016

@bors-servo retry #11574 #11703
@nox nox added S-awaiting-merge and removed S-tests-failed labels Jul 6, 2016
@KiChjang
Copy link
Member

KiChjang commented Jul 6, 2016

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

⌛ Testing commit 74a4d76 with merge bb1c2fe...
bors-servo added a commit that referenced this pull request Jul 6, 2016
@bors-servo
Auto merge of #12208 - nox:fontloading, r=metajack
bb1c2fe 
Continue loading font-face sources on missing local font

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12208)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Jul 6, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

⌛ Testing commit 74a4d76 with merge 3679b0a...
bors-servo added a commit that referenced this pull request Jul 6, 2016
@bors-servo
Auto merge of #12208 - nox:fontloading, r=metajack
Loading status checks…
3679b0a 
Continue loading font-face sources on missing local font

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12208)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 74a4d76 into servo:master Jul 6, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang mentioned this pull request Jul 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @metajack @bors-servo @KiChjang @asajeffrey
You can’t perform that action at this time.