Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't load stylesheets in documents without browsing contexts #12241
Conversation
highfive
commented
Jul 4, 2016
|
Heads up! This PR modifies the following files:
|
|
Are you sure 1495, a long-closed bug about heap corruption on Android, is related to this? |
|
My mistake, I meant whatwg/html#1495. |
|
Reviewed 4 of 4 files at r1. Comments from Reviewable |
|
@bors-servo delegate=notriddle |
|
|
|
@bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 5, 2016
Don't load stylesheets in documents without browsing contexts Per whatwg/html#1495, this fixes the most commonly reported panic in nightlies by making us match what other browsers do. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12047 (github issue number if applicable). - [X] There are tests for these changes OR <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12241) <!-- Reviewable:end -->
|
|
This was referenced Jul 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJul 4, 2016
•
edited
Per whatwg/html#1495, this fixes the most commonly reported panic in nightlies by making us match what other browsers do.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is