Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DataSlice, fix #12249 #12258

Merged
merged 1 commit into from Jul 5, 2016
Merged

Remove DataSlice, fix #12249 #12258

merged 1 commit into from Jul 5, 2016

Conversation

@izgzhen
Copy link
Contributor

izgzhen commented Jul 5, 2016 •
edited

r? @Manishearth

This change is Reviewable
@izgzhen
Remove DataSlice, fix #12249
Loading status checks…
ab14777
@highfive
Copy link

highfive commented Jul 5, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/filemanager_thread.rs, components/script/dom/testbinding.rs, components/script/dom/file.rs, components/script/dom/xmlhttprequest.rs, components/net_traits/filemanager_thread.rs, components/net_traits/filemanager_thread.rs, components/script/dom/htmlformelement.rs, components/script/dom/filereader.rs, components/script/dom/websocket.rs, components/script/dom/blob.rs, components/script/dom/formdata.rs
@Manishearth
Copy link
Member

Manishearth commented Jul 5, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

📌 Commit ab14777 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

⌛ Testing commit ab14777 with merge 87c7772...
bors-servo added a commit that referenced this pull request Jul 5, 2016
@bors-servo
Auto merge of #12258 - izgzhen:remove-data-slice, r=Manishearth
Loading status checks…
87c7772 
Remove DataSlice, fix #12249

r? @Manishearth

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12249

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12258)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit ab14777 into servo:master Jul 5, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jul 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove DataSlice structure in Blob backend implementation
4 participants
@izgzhen @highfive @Manishearth @bors-servo
You can’t perform that action at this time.