Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMissing steps of Characteristic's readValue, writeValue functions #12261
Conversation
highfive
commented
Jul 5, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 5, 2016
|
|
|
-S-awaiting-review +S-needs-code-changes Reviewed 1 of 1 files at r1. components/script/dom/bluetoothremotegattcharacteristic.rs, line 193 [r1] (raw file):
This should be an InvalidModification error. You can add ones that don't exist in dom/bindings/errors.rs. Comments from Reviewable |
zakorgy
force-pushed the
szeged:gattcharacteristicfunctions
branch
from
ce7c2e7
to
52e1d83
|
@bors-servo: r+ |
|
|
Missing steps of Characteristic's readValue, writeValue functions <!-- Please describe your changes on the following line: --> Add a check for the read property of the characteristic as described in https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-readvalue (Step 4.1) Add two missing steps to characteristic's WriteValue function. https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-writevalue (Step 4 and 5) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because, there are no Web Bluetooth test API implementation yet. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12261) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
zakorgy commentedJul 5, 2016
•
edited by larsbergstrom
Add a check for the read property of the characteristic as described in https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-readvalue (Step 4.1)
Add two missing steps to characteristic's WriteValue function. https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-writevalue (Step 4 and 5)
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is