Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make geckolib possible to build on stable Rust #12263

Merged
merged 1 commit into from Jul 6, 2016
Merged

Make geckolib possible to build on stable Rust #12263

merged 1 commit into from Jul 6, 2016

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jul 5, 2016 •
edited by larsbergstrom

More for #11815

r? @nox

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Jul 5, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/stylesheets.rs, components/style/properties/helpers.mako.rs, components/style/properties/helpers/animated_properties.mako.rs, components/style/keyframes.rs, components/style/properties/longhand/box.mako.rs
@highfive
Copy link

highfive commented Jul 5, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@SimonSapin SimonSapin mentioned this pull request Jul 5, 2016
Closed
7 of 7 tasks complete
ports/geckolib/Cargo.toml
@@ -36,15 +36,15 @@ lazy_static = "0.2"
libc = "0.2"
log = {version = "0.3.5", features = ["release_max_level_info"]}
num_cpus = "0.2.2"
selectors = {version = "0.6", features = ["unstable"]}
selectors = "0.6"

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Jul 5, 2016

Member

We should probably add selectors/unstable to the features list?

This comment has been minimized.

Sign in to view
@SimonSapin

SimonSapin Jul 5, 2016

Author Member

Do you mean to the servo feature? Yes, done.
@SimonSapin
Make geckolib possible to build on stable Rust
Loading status checks…
2d52b13
@SimonSapin SimonSapin force-pushed the stable-geckolib branch from 79d94dd to 2d52b13 Jul 5, 2016
@Manishearth
Copy link
Member

Manishearth commented Jul 5, 2016

LGTM
@nox
Copy link
Member

nox commented Jul 5, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

📌 Commit 2d52b13 has been approved by nox
@bholley
Copy link
Contributor

bholley commented Jul 5, 2016

I need to base a PR on this. @bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

⌛ Testing commit 2d52b13 with merge 67db6b1...
bors-servo added a commit that referenced this pull request Jul 5, 2016
@bors-servo
Auto merge of #12263 - servo:stable-geckolib, r=nox
67db6b1 
Make geckolib possible to build on stable Rust

<!-- Please describe your changes on the following line: -->

More for #11815

r? @nox

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12263)
<!-- Reviewable:end -->
@bholley bholley mentioned this pull request Jul 5, 2016
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Jul 5, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform3d-translatez-001.htm
  └   → /css-transforms-1_dev/html/transform3d-translatez-001.htm 902d90a8d198625335e738587fdfe81dcc90392d
/css-transforms-1_dev/html/reference/transform3d-translatez-ref.htm b14318ccfd8a59b7b249d41521e178d617678823
Testing 902d90a8d198625335e738587fdfe81dcc90392d == b14318ccfd8a59b7b249d41521e178d617678823
/css-transforms-1_dev/html/transform3d-translatez-001.htm 902d90a8d198625335e738587fdfe81dcc90392d
/css-transforms-1_dev/html/reference/transform3d-translatez-notref.htm 902d90a8d198625335e738587fdfe81dcc90392d
Testing 902d90a8d198625335e738587fdfe81dcc90392d != 902d90a8d198625335e738587fdfe81dcc90392d
@jdm
Copy link
Member

jdm commented Jul 5, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

💔 Test failed - linux-rel
@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 5, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

⌛ Testing commit 2d52b13 with merge 3d557b6...
bors-servo added a commit that referenced this pull request Jul 5, 2016
@bors-servo
Auto merge of #12263 - servo:stable-geckolib, r=nox
Loading status checks…
3d557b6 
Make geckolib possible to build on stable Rust

<!-- Please describe your changes on the following line: -->

More for #11815

r? @nox

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12263)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Jul 5, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 2d52b13 into master Jul 6, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the stable-geckolib branch Jul 6, 2016
@SimonSapin SimonSapin mentioned this pull request Jul 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@SimonSapin @highfive @Manishearth @nox @bors-servo @bholley @jdm
You can’t perform that action at this time.