Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't warn about reopening a crashed Servo window on Mac #12267
Merged
Conversation
Info.plist
Outdated
| <key>CFBundleIconFile</key> | ||
| <string>servo.icns</string> | ||
| <key>CFBundleIdentifier</key> | ||
| <string>org.servo.Servo22</string> |
This comment has been minimized.
This comment has been minimized.
metajack
Jul 5, 2016
Contributor
Oh man. My little hacks made it all the way here? This should be org.servo.Servo. We can do it in a followup I guess, but it would be really easy to fix here.
|
r=me with the s/Servo22/Servo/ or with a bug filed for that. |
|
@bors-servo r=metajack |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 6, 2016
Don't warn about reopening a crashed Servo window on Mac Mac warns about reopening an application that crashed in the last run. With Servo this is quite often the case, so we should get rid of the dialog. Generated by running http://stackoverflow.com/a/20291771/1198729 on the plist file directly, and then using plutil to convert back to xml. It got prettified in the process. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12267) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJul 5, 2016
•
edited by larsbergstrom
Mac warns about reopening an application that crashed in the last run. With Servo this is
quite often the case, so we should get rid of the dialog.
Generated by running http://stackoverflow.com/a/20291771/1198729 on the plist file directly,
and then using plutil to convert back to xml. It got prettified in the process.
This change is