Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSnap text baseline to nearest pixel before positioning glyphs #12270
Conversation
|
@bors-servo: r+ Wow, this looks like an annoying bug. |
|
|
|
|
|
@bors-servo r=pcwalton |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 6, 2016
Snap text baseline to nearest pixel before positioning glyphs Fixes a test failure on Mac caused by sub-pixel-positioned glyphs being rounded in different directions depending on the baseline offset. r? @pcwalton --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12270) <!-- Reviewable:end -->
|
|
highfive
commented
Jul 6, 2016
|
|
@bors-servo try Should this be closed or we still want this patch @mbrubeck? |
bors-servo
added a commit
that referenced
this pull request
Nov 10, 2016
Snap text baseline to nearest pixel before positioning glyphs Fixes a test failure on Mac caused by sub-pixel-positioned glyphs being rounded in different directions depending on the baseline offset. r? @pcwalton --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12270) <!-- Reviewable:end -->
|
We still need something like this patch, but I'm not sure whether this is the exact right solution. I don't currently have a working macOS dev environment, so it would help if someone can take this over. (If not, I can work on getting a Mac set up again…) |
|
|
|
Tracking it in #15272. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedJul 5, 2016
•
edited by larsbergstrom
Fixes a test failure on Mac caused by sub-pixel-positioned glyphs being rounded in different directions depending on the baseline offset. r? @pcwalton
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is