Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation location for downloaded std packages #12271

Merged
merged 1 commit into from Jul 6, 2016

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Jul 5, 2016

Fixes a "can't find crate for std" error in mach build. Regression from #11945. r? @larsbergstrom


This change is Reviewable

@mbrubeck mbrubeck changed the title Fix error in cross-compiling bootstrap Fix installation location for downloaded std packages Jul 5, 2016
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Jul 5, 2016

Note: People affected by this bug may need to run ./mach boostrap-rust --force after this patch is merged.

@emilio
Copy link
Member

emilio commented Jul 5, 2016

@bors-servo: r+

Quoting @mbrubeck:

It's just restoring some parens that were accidentally removed.

@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

📌 Commit a824177 has been approved by emilio

@highfive highfive assigned emilio and unassigned larsbergstrom Jul 5, 2016
@izgzhen izgzhen mentioned this pull request Jul 6, 2016
@KiChjang
Copy link
Member

KiChjang commented Jul 6, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

Testing commit a824177 with merge beff8ee...

bors-servo added a commit that referenced this pull request Jul 6, 2016
Fix installation location for downloaded std packages

Fixes a "can't find crate for `std`" error in mach build. Regression from #11945. r? @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12271)
<!-- Reviewable:end -->
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 6, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, windows are reusable. Rebuilding only linux-rel, mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

💔 Test failed - linux-rel

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 6, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

@bors-servo bors-servo merged commit a824177 into servo:master Jul 6, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck deleted the mbrubeck:host_triple branch May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.