Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse report_pending_exception in CallSetup. #12272

Merged
merged 1 commit into from Jul 7, 2016
Merged

Reuse report_pending_exception in CallSetup. #12272

merged 1 commit into from Jul 7, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 5, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Reuse report_pending_exception in CallSetup.
Loading status checks…
7254000
@highfive
Copy link

highfive commented Jul 5, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/bindings/callback.rs
@highfive
Copy link

highfive commented Jul 5, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jul 5, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

📌 Commit 7254000 has been approved by jdm
@highfive highfive assigned jdm and unassigned emilio Jul 5, 2016
@nox
Copy link
Member

nox commented Jul 6, 2016 •
edited

No test...? Am stupid.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

⌛ Testing commit 7254000 with merge dfba260...
bors-servo added a commit that referenced this pull request Jul 6, 2016
@bors-servo
Auto merge of #12272 - Ms2ger:report, r=jdm
dfba260 
Reuse report_pending_exception in CallSetup.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12272)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 6, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Jul 7, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2016

⌛ Testing commit 7254000 with merge 4fafcb1...
bors-servo added a commit that referenced this pull request Jul 7, 2016
@bors-servo
Auto merge of #12272 - Ms2ger:report, r=jdm
Loading status checks…
4fafcb1 
Reuse report_pending_exception in CallSetup.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12272)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 7254000 into servo:master Jul 7, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jul 7, 2016
Merged
@Ms2ger Ms2ger deleted the Ms2ger:report branch Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @jdm @bors-servo @nox @emilio
You can’t perform that action at this time.