Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upProperly check storage size against QUOTA_SIZE_LIMIT (fixes #12247) #12289
Conversation
highfive
commented
Jul 6, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 6, 2016
|
|
components/net/storage_thread.rs
Outdated
| let local_data = self.select_data(StorageType::Local); | ||
| let session_data = self.select_data(StorageType::Session); | ||
| let local_data_size = local_data.get(&origin).map_or(0, |&(total, _)| total); | ||
| let session_data_size = session_data.get(&origin).map_or(0, |&(total, _)| total); | ||
| local_data_size + session_data_size | ||
| if storage_type == StorageType::Local { |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=Ms2ger |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 7, 2016
Properly check storage size against QUOTA_SIZE_LIMIT (fixes #12247) <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12289) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedJul 6, 2016
•
edited by larsbergstrom
This change is