[Do Not Merge] Make DOM Manipulation events cancellable #12296

cbrewster · 2016-07-06T20:31:07Z

I can't reproduce the intermittent failure on #11703 so I am running some tests using buildbot.
If this does fix the intermittent, this is blocked on #12292.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #11703 (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because _____

This change is

highfive · 2016-07-06T20:31:11Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/storage.rs, components/script/dom/event.rs, components/script/dom/htmldetailselement.rs, components/script/dom/htmlformelement.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/htmlimageelement.rs, components/script/script_thread.rs, components/script/task_source/dom_manipulation.rs

highfive · 2016-07-06T20:31:12Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

cbrewster · 2016-07-06T20:31:19Z

@bors-servo try


        Auto merge of #12296 - ConnorGBrewster:dommanip_intermittent, r=<try>

[Do Not Merge] Make DOM Manipulation events cancellable  I can't reproduce the intermittent failure on #11703 so I am running some tests using buildbot. If this does fix the intermittent, this is blocked on #12292. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____

bors-servo · 2016-07-06T20:31:23Z

⌛ Trying commit 7bff05e with merge 2185c18...

bors-servo · 2016-07-06T20:58:36Z

💔 Test failed - mac-rel-wpt

cbrewster · 2016-07-06T21:19:45Z

@bors-servo try

bors-servo · 2016-07-06T21:19:48Z

⌛ Trying commit aaba316 with merge 1b88d31...


        Auto merge of #12296 - ConnorGBrewster:dommanip_intermittent, r=<try>

[Do Not Merge] Make DOM Manipulation events cancellable  I can't reproduce the intermittent failure on #11703 so I am running some tests using buildbot. If this does fix the intermittent, this is blocked on #12292. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12296)

bors-servo · 2016-07-06T22:40:34Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

cbrewster · 2016-07-06T22:41:36Z

@bors-servo retry

bors-servo · 2016-07-06T22:41:39Z

⌛ Trying commit aaba316 with merge f91a158...


        Auto merge of #12296 - ConnorGBrewster:dommanip_intermittent, r=<try>

[Do Not Merge] Make DOM Manipulation events cancellable  I can't reproduce the intermittent failure on #11703 so I am running some tests using buildbot. If this does fix the intermittent, this is blocked on #12292. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12296)

bors-servo · 2016-07-06T23:44:23Z

💔 Test failed - linux-rel

highfive · 2016-07-06T23:45:03Z

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform3d-translatez-001.htm
  └   → /css-transforms-1_dev/html/transform3d-translatez-001.htm 902d90a8d198625335e738587fdfe81dcc90392d
/css-transforms-1_dev/html/reference/transform3d-translatez-ref.htm b14318ccfd8a59b7b249d41521e178d617678823
Testing 902d90a8d198625335e738587fdfe81dcc90392d == b14318ccfd8a59b7b249d41521e178d617678823
/css-transforms-1_dev/html/transform3d-translatez-001.htm 902d90a8d198625335e738587fdfe81dcc90392d
/css-transforms-1_dev/html/reference/transform3d-translatez-notref.htm 902d90a8d198625335e738587fdfe81dcc90392d
Testing 902d90a8d198625335e738587fdfe81dcc90392d != 902d90a8d198625335e738587fdfe81dcc90392d

cbrewster · 2016-07-06T23:47:15Z

@bors-servo retry

bors-servo · 2016-07-06T23:47:18Z

⌛ Trying commit aaba316 with merge 439128f...


        Auto merge of #12296 - ConnorGBrewster:dommanip_intermittent, r=<try>

[Do Not Merge] Make DOM Manipulation events cancellable  I can't reproduce the intermittent failure on #11703 so I am running some tests using buildbot. If this does fix the intermittent, this is blocked on #12292. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12296)

bors-servo · 2016-07-07T00:55:41Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

notriddle · 2016-07-07T02:31:46Z

@bors-servo retry

bors-servo · 2016-07-07T02:31:49Z

⌛ Trying commit aaba316 with merge 49da17d...


        Auto merge of #12296 - ConnorGBrewster:dommanip_intermittent, r=<try>

[Do Not Merge] Make DOM Manipulation events cancellable  I can't reproduce the intermittent failure on #11703 so I am running some tests using buildbot. If this does fix the intermittent, this is blocked on #12292. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12296)

bors-servo · 2016-07-07T03:28:53Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

cbrewster · 2016-07-07T03:41:25Z

@bors-servo retry

bors-servo · 2016-07-07T03:41:28Z

⌛ Trying commit aaba316 with merge 34dbe1c...


        Auto merge of #12296 - ConnorGBrewster:dommanip_intermittent, r=<try>

[Do Not Merge] Make DOM Manipulation events cancellable  I can't reproduce the intermittent failure on #11703 so I am running some tests using buildbot. If this does fix the intermittent, this is blocked on #12292. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12296)

bors-servo · 2016-07-07T04:36:58Z

💔 Test failed - mac-rel-wpt

highfive · 2016-07-07T04:39:12Z

  ▶ TIMEOUT [expected OK] /html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-support.htm

cbrewster · 2016-07-07T06:05:51Z

@bors-servo retry

bors-servo · 2016-07-07T06:05:53Z

⌛ Trying commit aaba316 with merge 93aae44...


        Auto merge of #12296 - ConnorGBrewster:dommanip_intermittent, r=<try>

[Do Not Merge] Make DOM Manipulation events cancellable  I can't reproduce the intermittent failure on #11703 so I am running some tests using buildbot. If this does fix the intermittent, this is blocked on #12292. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11703 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12296)

cbrewster · 2016-07-07T06:10:59Z

I have not found a way to write a test to reproduce this (although I have found many other panics along the way). Any ideas would be appreciated. The test should somehow fire a DOMManipulation event to a target whose script thread is shut down.

bors-servo · 2016-07-07T07:00:59Z

💔 Test failed - mac-rel-wpt

KiChjang · 2016-07-07T08:45:09Z

Looks like the last try run has been killed by the OS.


        Make dom manipulation events cancellable


        enable change parentage test

KiChjang · 2016-07-08T08:52:15Z

Can we reduce the change_parentage test down into a minimal case where the bug before this patch can deterministically happen?

cbrewster · 2016-07-08T13:27:04Z

@KiChjang I have not been able to do so, I can't even get change_parentage to crash locally after 400+ test runs.

cbrewster · 2016-07-12T06:00:27Z

Closing in favor of #12404 as it makes all tasks cancellable.

highfive assigned nox Jul 6, 2016

highfive added the S-awaiting-review label Jul 6, 2016

highfive added the S-tests-failed label Jul 6, 2016

cbrewster force-pushed the cbrewster:dommanip_intermittent branch from 7bff05e to 3248f52 Jul 6, 2016

highfive removed the S-tests-failed label Jul 6, 2016

cbrewster force-pushed the cbrewster:dommanip_intermittent branch from 3248f52 to aaba316 Jul 6, 2016

highfive added the S-tests-failed label Jul 6, 2016

highfive added the S-tests-failed label Jul 7, 2016

cbrewster added the S-blocked-on-external label Jul 7, 2016

highfive added the S-tests-failed label Jul 7, 2016

cbrewster removed the S-blocked-on-external label Jul 8, 2016

Make dom manipulation events cancellable

Loading status checks…

0791710

cbrewster force-pushed the cbrewster:dommanip_intermittent branch from aaba316 to 0791710 Jul 8, 2016

highfive removed the S-tests-failed label Jul 8, 2016

enable change parentage test

Loading status checks…

3df9ec3

cbrewster closed this Jul 12, 2016

servo / servo

[Do Not Merge] Make DOM Manipulation events cancellable #12296

[Do Not Merge] Make DOM Manipulation events cancellable #12296

cbrewster commented Jul 6, 2016 •

edited

highfive commented Jul 6, 2016

highfive commented Jul 6, 2016

cbrewster commented Jul 6, 2016

bors-servo commented Jul 6, 2016

bors-servo commented Jul 6, 2016

cbrewster commented Jul 6, 2016

bors-servo commented Jul 6, 2016

bors-servo commented Jul 6, 2016

cbrewster commented Jul 6, 2016

bors-servo commented Jul 6, 2016

bors-servo commented Jul 6, 2016

highfive commented Jul 6, 2016

cbrewster commented Jul 6, 2016

bors-servo commented Jul 6, 2016

bors-servo commented Jul 7, 2016

notriddle commented Jul 7, 2016

bors-servo commented Jul 7, 2016

bors-servo commented Jul 7, 2016

cbrewster commented Jul 7, 2016

bors-servo commented Jul 7, 2016

bors-servo commented Jul 7, 2016

highfive commented Jul 7, 2016

cbrewster commented Jul 7, 2016

bors-servo commented Jul 7, 2016

cbrewster commented Jul 7, 2016

bors-servo commented Jul 7, 2016

KiChjang commented Jul 7, 2016

KiChjang commented Jul 8, 2016

cbrewster commented Jul 8, 2016

cbrewster commented Jul 12, 2016

servo / servo

Join GitHub today

[Do Not Merge] Make DOM Manipulation events cancellable #12296

[Do Not Merge] Make DOM Manipulation events cancellable #12296

Conversation

cbrewster commented Jul 6, 2016 • edited

highfive commented Jul 6, 2016

highfive commented Jul 6, 2016

cbrewster commented Jul 6, 2016

bors-servo commented Jul 6, 2016

bors-servo commented Jul 6, 2016

cbrewster commented Jul 6, 2016

bors-servo commented Jul 6, 2016

bors-servo commented Jul 6, 2016

cbrewster commented Jul 6, 2016

bors-servo commented Jul 6, 2016

bors-servo commented Jul 6, 2016

highfive commented Jul 6, 2016

cbrewster commented Jul 6, 2016

bors-servo commented Jul 6, 2016

bors-servo commented Jul 7, 2016

notriddle commented Jul 7, 2016

bors-servo commented Jul 7, 2016

bors-servo commented Jul 7, 2016

cbrewster commented Jul 7, 2016

bors-servo commented Jul 7, 2016

bors-servo commented Jul 7, 2016

highfive commented Jul 7, 2016

cbrewster commented Jul 7, 2016

bors-servo commented Jul 7, 2016

cbrewster commented Jul 7, 2016

bors-servo commented Jul 7, 2016

KiChjang commented Jul 7, 2016

KiChjang commented Jul 8, 2016

cbrewster commented Jul 8, 2016

cbrewster commented Jul 12, 2016

cbrewster commented Jul 6, 2016 •

edited