Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate browserhtml version to 0.1.15 #12302
Merged
Conversation
highfive
commented
Jul 6, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 7, 2016
Update browserhtml version to 0.1.15 Update browserhtml version to 0.1.15 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] ~~These changes fix #__ (github issue number if applicable).~~ <!-- Either: --> - [ ] ~~There are tests for these changes OR~~ - [x] These changes do not require tests because it just updates dependency <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12302) <!-- Reviewable:end -->
|
|
|
I doubt my changes are a reason for that test failure. @ConnorGBrewster what should I do next to get this inn ? |
|
@Gozala we are having some infra issues, hopefully we should be up and running again soon. Nothing wrong here. |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 8, 2016
Update browserhtml version to 0.1.15 Update browserhtml version to 0.1.15 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] ~~These changes fix #__ (github issue number if applicable).~~ <!-- Either: --> - [ ] ~~There are tests for these changes OR~~ - [x] These changes do not require tests because it just updates dependency <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12302) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Gozala commentedJul 6, 2016
•
edited by larsbergstrom
Update browserhtml version to 0.1.15
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThese changes fix #__ (github issue number if applicable).There are tests for these changes ORThis change is