Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBlockify elements in a flex container #12361
Merged
Conversation
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Jul 9, 2016
Blockify elements in a flex container <!-- Please describe your changes on the following line: --> The is one of my pull requests that implement basic flexible box layout. As the spec stated in https://drafts.csswg.org/css-flexbox/#flex-items , A inline-level child of a flex container should be converted to its block equivalent, according to CSS2.1 § 9.7. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because flexbox is not actually implemented yet. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12361) <!-- Reviewable:end -->
|
|
|
I'm confused about why these two tests now time out with these changes... |
|
Not very sure. One of the possibility is that currently flex flow is not treat as block in float calculation while in these two tests these containers as declared as floats, and with this patch servo had a hard time resolving block sizes. Once other patches are landed the time out should disappear. |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 11, 2016
Blockify elements in a flex container <!-- Please describe your changes on the following line: --> The is one of my pull requests that implement basic flexible box layout. As the spec stated in https://drafts.csswg.org/css-flexbox/#flex-items , A inline-level child of a flex container should be converted to its block equivalent, according to CSS2.1 § 9.7. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because flexbox is not actually implemented yet. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12361) <!-- Reviewable:end -->
|
|
highfive
commented
Jul 11, 2016
|
|
@jdm The time out disappeared as expected |
A inline-level child of a flex container should be converted to its block equivalent. according to CSS2.1 § 9.7.
|
(tracking #12453) |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 18, 2016
Blockify elements in a flex container <!-- Please describe your changes on the following line: --> The is one of my pull requests that implement basic flexible box layout. As the spec stated in https://drafts.csswg.org/css-flexbox/#flex-items , A inline-level child of a flex container should be converted to its block equivalent, according to CSS2.1 § 9.7. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because flexbox is not actually implemented yet. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12361) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
stshine commentedJul 9, 2016
•
edited
The is one of my pull requests that implement basic flexible box layout.
As the spec stated in https://drafts.csswg.org/css-flexbox/#flex-items ,
A inline-level child of a flex container should be converted to its block equivalent, according to CSS2.1 § 9.7.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is