Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12071: Don't submit forms when typing Tab on an input. #12365

Merged
merged 1 commit into from Jul 13, 2016
Merged

Issue #12071: Don't submit forms when typing Tab on an input. #12365

merged 1 commit into from Jul 13, 2016

Conversation

@simartin
Copy link
Contributor

simartin commented Jul 9, 2016 •
edited by larsbergstrom

Fixes #12071

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #12071
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Jul 9, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmlinputelement.rs
components/script/dom/htmlinputelement.rs Outdated
keyevent.ShiftKey(),
keyevent.AltKey(),
keyevent.MetaKey()),
// Issue #12071

This comment has been minimized.

Sign in to view
Copy link
@notriddle

notriddle Jul 10, 2016 •
edited

Contributor

Could you include an actual synopsis? Something like

// TODO(3982): Implement tab focus switching

This comment has been minimized.

Sign in to view
Copy link
@simartin

simartin Jul 10, 2016

Author Contributor

Thanks for the suggestion and the issue # for keyboard navigation. Done in the updated patch
@simartin simartin force-pushed the simartin:issue_12071 branch from 9e7d067 to 9547633 Jul 10, 2016
tests/wpt/mozilla/tests/mozilla/form_tab_keyevent.html Outdated
});
test.step_timeout(function() { assert_false(form_submitted, "Form should not be submitted"); test.done(); }, 500);
</script>
</body>

This comment has been minimized.

Sign in to view
Copy link
@KiChjang

KiChjang Jul 11, 2016

Member

Woah, there are tabs in this test file. Doubleplusungood. Please change them into spaces (either 2 or 4 spaces per indent are fine).
@notriddle
Copy link
Contributor

notriddle commented Jul 12, 2016

Why didn't tidy catch it?
@simartin
Issue #12071: Don't submit forms when typing Tab on an input.
Loading status checks…
ff4e07b
@simartin simartin force-pushed the simartin:issue_12071 branch from 9547633 to ff4e07b Jul 12, 2016
@simartin
Copy link
Contributor Author

simartin commented Jul 12, 2016

tests/wpt/mozilla/tests/mozilla/form_tab_keyevent.html, line 26 [r2] (raw file):

Previously, KiChjang (Keith Yeung) wrote…

Woah, there are tabs in this test file. Doubleplusungood. Please change them into spaces (either 2 or 4 spaces per indent are fine).

Patch updated accordingly. Thanks

Comments from Reviewable
@simartin simartin mentioned this pull request Jul 12, 2016
Closed
@simartin
Copy link
Contributor Author

simartin commented Jul 12, 2016

tidy did not catch it because it does not consider *.html files. I've opened #12421 to fix this.

Comments from Reviewable
@KiChjang
Copy link
Member

KiChjang commented Jul 12, 2016

@bors-servo r+

Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2016

📌 Commit ff4e07b has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2016

⌛ Testing commit ff4e07b with merge 3c3c32f...
bors-servo added a commit that referenced this pull request Jul 12, 2016
@bors-servo
Auto merge of #12365 - simartin:issue_12071, r=KiChjang
Loading status checks…
3c3c32f 
Issue #12071: Don't submit forms when typing Tab on an input.

<!-- Please describe your changes on the following line: -->
Fixes #12071
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12071

<!-- Either: -->
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12365)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit ff4e07b into servo:master Jul 13, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@simartin simartin deleted the simartin:issue_12071 branch Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

using tab for username/pass entry causes submit
5 participants
@simartin @highfive @notriddle @KiChjang @bors-servo
You can’t perform that action at this time.