Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build geckolib with MozillaBuild on Windows #12377

Merged
merged 2 commits into from Jul 11, 2016
+4 −2
Merged

Build geckolib with MozillaBuild on Windows #12377

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb62b5d
Ensure all env vars are str
upsuper Jul 11, 2016
ce2447f
Change to use msvc triple for Windows Python
upsuper Jul 11, 2016
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Ensure all env vars are str 

This is necessary for the Python build bundled in MozillaBuild.
  • Loading branch information
@upsuper
upsuper committed Jul 11, 2016
commit cb62b5dd2663f0967900a865f3ae1d1e49d15cf9
2 python/servo/build_commands.py
View file
Open in desktop
@@ -332,7 +332,7 @@ def build_geckolib(self, jobs=None, verbose=False, release=False):
opts += ["--release"]

env = self.build_env()
env["CARGO_TARGET_DIR"] = path.join(self.context.topdir, "target", "geckolib")
env["CARGO_TARGET_DIR"] = path.join(self.context.topdir, "target", "geckolib").encode("UTF-8")

build_start = time()
with cd(path.join("ports", "geckolib")):
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.