Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRename check_no_unwrap.sh to check_no_panic.sh #12384
Closed
+3
−3
Conversation
highfive
commented
Jul 11, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
highfive
commented
Jul 11, 2016
|
Heads up! This PR modifies the following files:
|
|
This is a duplicate of #10942. If the status of #10942 wasn't clear, it is being blocked from merging into master because of servo/saltfs#316. |
|
Except this PR is passing. |
|
Yes, because we control the travis CI environment from .travis.yml. The steps are different for our non-travis build machines. |
|
I'm going to close this in favour of #10942. Thanks for trying to solve it, however! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zeusintuivo commentedJul 11, 2016
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is