Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename check_no_unwrap.sh to check_no_panic.sh #12384

Closed
wants to merge 2 commits into from

Conversation

@zeusintuivo
Copy link
Contributor

zeusintuivo commented Jul 11, 2016

  • rename etc/ci/check_no_unwrap.sh to etc/ci/check_no_panic.sh
  • Replaced check_no_unwrap for check_no_panic
  • Rebased against Origin Mozilla/Master
  • Ran the build and tidy below without errors

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #10930 (github issue number if applicable).

This change is Reviewable

@highfive
Copy link

highfive commented Jul 11, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

@highfive
Copy link

highfive commented Jul 11, 2016

Heads up! This PR modifies the following files:

  • @aneeshusa: etc/ci/check_no_panic.sh, etc/ci/check_no_unwrap.sh, etc/ci/buildbot_steps.yml
@KiChjang
Copy link
Member

KiChjang commented Jul 11, 2016

This is a duplicate of #10942. If the status of #10942 wasn't clear, it is being blocked from merging into master because of servo/saltfs#316.

@zeusintuivo zeusintuivo changed the title Feature/10930 Rename check_no_unwrap.sh to check_no_panic.sh Rename check_no_unwrap.sh to check_no_panic.sh Jul 11, 2016
@zeusintuivo zeusintuivo force-pushed the zeusintuivo:feature/10930 branch from 9606e30 to 6749a50 Jul 11, 2016
@zeusintuivo
Copy link
Contributor Author

zeusintuivo commented Jul 11, 2016

Except this PR is passing.

@jdm
Copy link
Member

jdm commented Jul 11, 2016

Yes, because we control the travis CI environment from .travis.yml. The steps are different for our non-travis build machines.

@jdm
Copy link
Member

jdm commented Jul 11, 2016

I'm going to close this in favour of #10942. Thanks for trying to solve it, however!

@jdm jdm closed this Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.